Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): dedupe semver #7130

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Sep 4, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link

socket-security bot commented Sep 4, 2023

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@wdio/cli 7.31.1...7.32.4 None +10/-6 10.1 MB wdio-user
@wdio/local-runner 7.31.1...7.32.4 None +12/-8 10.2 MB wdio-user
@wdio/browserstack-service 7.31.1...7.32.4 filesystem, environment +12/-7 10.4 MB wdio-user
appium-adb 9.11.4...9.14.11 None +7/-37 2.79 MB kazucocoa
@wdio/cucumber-framework 7.31.1...7.32.3 None +11/-7 10.2 MB wdio-user

@socket-security
Copy link

socket-security bot commented Sep 4, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: @types/puppeteer@7.0.4

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0e2b28c) 34.59% compared to head (f229296) 34.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7130   +/-   ##
=======================================
  Coverage   34.59%   34.59%           
=======================================
  Files        1017     1017           
  Lines       27150    27150           
  Branches     2211     2211           
=======================================
  Hits         9393     9393           
  Misses      17268    17268           
  Partials      489      489           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@legobeat legobeat force-pushed the deps-dedupe-semver branch 2 times, most recently from 537feaa to a403832 Compare September 21, 2023 00:27
@legobeat legobeat added dependencies Pull requests that update a dependency file team-security labels Sep 21, 2023
@legobeat
Copy link
Contributor Author

@SocketSecurity ignore @types/puppeteer@7.0.4

should be solved in appium

@legobeat legobeat marked this pull request as ready for review September 30, 2023 02:46
@legobeat legobeat requested a review from a team as a code owner September 30, 2023 02:46
Copy link
Contributor

@leotm leotm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 additional semver dedupes within

  • @storybook/manager-webpack5@6.5.16
  • @wdio/cucumber-framework@7.32.3
  • metro-react-native-babel-preset@0.73.9

@legobeat legobeat merged commit 46b493b into MetaMask:main Oct 2, 2023
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2023
@legobeat legobeat deleted the deps-dedupe-semver branch October 2, 2023 00:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file team-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants