Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update confirmation page layout for blockaid alerts #7140

Merged
merged 85 commits into from
Sep 15, 2023
Merged

Update confirmation page layout for blockaid alerts #7140

merged 85 commits into from
Sep 15, 2023

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Sep 5, 2023 •
edited

Update confirmation pages layout for blockaid alerts:

Screen.Recording.2023-09-05.at.3.04.17.PM.mov
Screen.Recording.2023-09-05.at.8.36.08.PM.mov

jpuri added 30 commits July 6, 2023 10:46
@jpuri jpuri marked this pull request as ready for review September 6, 2023 03:47
@jpuri jpuri requested a review from a team as a code owner September 6, 2023 03:47
@jpuri jpuri changed the title Update confirmation page layout of blcokaid alerts Update confirmation page layout for blockaid alerts Sep 6, 2023
blackdevelopa
blackdevelopa previously approved these changes Sep 8, 2023
View reviewed changes
app/components/UI/TransactionReview/index.js Show resolved Hide resolved
@blackdevelopa
Copy link
Contributor

Hi @jpuri, just noticing that for token approval, the style is a bit off
Screenshot 2023-09-08 at 15 08 52

Base automatically changed from blockaid_banner_integration to main September 12, 2023 15:16
@jpuri jpuri dismissed blackdevelopa’s stale review September 12, 2023 15:16

The base branch was changed.

@jpuri
Copy link
Contributor Author

jpuri commented Sep 12, 2023

Hi @jpuri, just noticing that for token approval, the style is a bit off Screenshot 2023-09-08 at 15 08 52

Yeh that is an existing thing @blackdevelopa

@jpuri jpuri added the team-confirmations-secure-ux-PR PR from the confirmations team label Sep 12, 2023
@seaona
Copy link
Contributor

seaona commented Sep 13, 2023 •
edited

@blackdevelopa yes this is an existing issue. We have a ticket for that here #7167

@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jpuri jpuri added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 14, 2023
@jpuri jpuri merged commit bd0e93c into main Sep 15, 2023
24 checks passed
@jpuri jpuri deleted the conf_page_layout_fix branch September 15, 2023 10:22
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 15, 2023
@metamaskbot metamaskbot added the release-7.8.0 Issue or pull request that will be included in release 7.8.0 label Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@segun segun segun approved these changes

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Assignees
No one assigned
Labels
release-7.8.0 Issue or pull request that will be included in release 7.8.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jpuri @codecov-commenter @blackdevelopa @seaona @segun @metamaskbot