Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 1078 mixpanel delete data #7141

Merged
merged 5 commits into from
Sep 8, 2023
Merged

fix: 1078 mixpanel delete data #7141

merged 5 commits into from
Sep 8, 2023

Conversation

frankvonhoven
Copy link
Contributor

@frankvonhoven frankvonhoven commented Sep 5, 2023 •
edited by NicolasMassart
Loading

Description
This PR changes the Mixpanel endpoint for deleting user data (MetaMetrics) to a proxy endpoint.

Screenshots/Recordings

Successful delete data request UI

Simulator Screen Shot - iPhone 14 - 2023-09-01 at 17 32 59

RECORDING

MixPanel-Delete.Data.mov

Issue

fixes 1078

Testing

  1. Go to settings screen > Security & Privacy
  2. Click on "Delete MetaMetrics Data" Button
  3. Confirm on Popup
  4. (Optional) Check Network tab in Flipper to watch POST & GET to proxy endpoint
  5. Should see UI update with requested delete data date as in screenshot

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@frankvonhoven frankvonhoven changed the title Fix/1078 mixpanel delete data Fix: 1078 mixpanel delete data Sep 5, 2023
@frankvonhoven frankvonhoven added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) next release team-mobile-client and removed next release labels Sep 7, 2023
@frankvonhoven frankvonhoven changed the title Fix: 1078 mixpanel delete data fix: 1078 mixpanel delete data Sep 7, 2023
@frankvonhoven frankvonhoven marked this pull request as ready for review September 7, 2023 20:03
@frankvonhoven frankvonhoven requested a review from a team as a code owner September 7, 2023 20:03
Cal-L
Cal-L reviewed Sep 8, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • How long does the disabled button state persist for?
  • Under what condition is it enabled again?

@Cal-L
Copy link
Contributor

Cal-L commented Sep 8, 2023

  • How long does the disabled button state persist for?
  • Under what condition is it enabled again?

Ah looks like it's a check every time the component mounts.

Cal-L
Cal-L approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Sep 8, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 33.33% and no project coverage change.

Comparison is base (808e647) 32.94% compared to head (89f86c5) 32.95%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7141   +/-   ##
=======================================
  Coverage   32.94%   32.95%           
=======================================
  Files        1005     1005           
  Lines       32642    32640    -2     
  Branches     8383     8383           
=======================================
  Hits        10755    10755           
+ Misses      21887    21885    -2
Files Changed Coverage Δ
app/core/Analytics/Analytics.js 4.54% <0.00%> (+0.04%) ⬆️
app/constants/urls.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sethkfman sethkfman added the release-7.8.0 Issue or pull request that will be included in release 7.8.0 label Sep 8, 2023
@Cal-L Cal-L added No QA Needed Apply this label when your PR does not need any QA effort. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. release-7.8.0 Issue or pull request that will be included in release 7.8.0 labels Sep 8, 2023
@Cal-L Cal-L merged commit d10ca86 into main Sep 8, 2023
27 of 30 checks passed
@Cal-L Cal-L deleted the fix/1078-mixpanel-delete-data branch September 8, 2023 22:42
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2023
@metamaskbot metamaskbot added the release-7.8.0 Issue or pull request that will be included in release 7.8.0 label Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.8.0 Issue or pull request that will be included in release 7.8.0 team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@frankvonhoven @Cal-L @codecov-commenter @gauthierpetetin @sethkfman @metamaskbot