Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: blockaid code fixes / updates #7145

Merged
merged 94 commits into from
Sep 21, 2023
Merged

fix: blockaid code fixes / updates #7145

merged 94 commits into from
Sep 21, 2023

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Sep 6, 2023 •
edited by seaona

The PR has small blockaid related code improvements:

  1. Fix the code to pass over securityAlertResponse to ReviewTransaction component
  2. Update ppom-validator package

Bitrise run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f210f984-8a6e-48f7-9aad-d60ed086bb35

jpuri added 30 commits July 6, 2023 10:46
@jpuri jpuri marked this pull request as ready for review September 6, 2023 14:04
@jpuri jpuri requested a review from a team as a code owner September 6, 2023 14:04
blackdevelopa
blackdevelopa reviewed Sep 8, 2023
View reviewed changes
Copy link
Contributor

@blackdevelopa blackdevelopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment that needs to be confirmed

@socket-security
Copy link

socket-security bot commented Sep 13, 2023 •
edited

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@jpuri jpuri added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 14, 2023
Base automatically changed from conf_page_layout_fix to main September 15, 2023 10:22
@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@jpuri jpuri changed the title Blockaid validation should be done on ethereum mainnet only Blockaid code improvements Sep 18, 2023
@jpuri jpuri changed the title Blockaid code improvements Fix: blockaid code fixes / updates Sep 18, 2023
@jpuri jpuri changed the title Fix: blockaid code fixes / updates fix: blockaid code fixes / updates Sep 18, 2023
@jpuri jpuri merged commit c762ea5 into main Sep 21, 2023
24 checks passed
@jpuri jpuri deleted the blockaid_mainnet_fix branch September 21, 2023 16:51
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@digiwand digiwand digiwand approved these changes

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Assignees
No one assigned
Labels
release-7.9.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jpuri @codecov-commenter @digiwand @blackdevelopa @metamaskbot