test: Screenshots on failure should only be done on the last retry for ios #7168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bitrise workflow
…tep for ios bitrise workflow
…tep for ios bitrise workflow
…roid bitrise workflow
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #7168 +/- ##
=======================================
Coverage 32.94% 32.94%
=======================================
Files 1005 1005
Lines 32642 32642
Branches 8383 8383
=======================================
Hits 10755 10755
Misses 21887 21887 ☔ View full report in Codecov by Sentry. |
|
Kudos, SonarCloud Quality Gate passed!
|
metamaskbot
added
the
release-7.8.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To improve the efficiency of test runs and reduce execution time, enabling concurrency within the tests can be beneficial. At this moment, the ios test are executed against two Simulators. However, screenshots are being generated and copied for failing scenarios that are passing in the retries. This can generate confusions to members of the team when seen that the build passed and you can download the screenshots from failing scripts.
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
fixes #???
Checklist