Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add JSDoc to deprecate Alert in favor of BannerAlert #6904 #7171

Merged
merged 7 commits into from
Oct 24, 2023

Conversation

Libens-bufo
Copy link
Contributor

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add the appropiate QA label when dev review is completed
    • needs-qa: PR requires manual QA.
    • No QA/E2E only: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.
    • Spot check on release build: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.
  5. Add QA Passed label when QA has signed off (Only required if the PR was labeled with needs-qa)
  6. Add your team's label, i.e. label starting with team- (or external-contributor label if your not a MetaMask employee)

Description

Add deprecation JSDoc to deprecated code in Alert.tsx

Screenshots/Recordings

Issue

fixes #6890

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@Libens-bufo Libens-bufo requested a review from a team as a code owner September 7, 2023 23:56
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Libens-bufo Libens-bufo changed the title Feature/deprecate ale docs: add JSDoc to deprecate Alert in favor of BannerAlert #6904 rt docs: add JSDoc to deprecate Alert in favor of BannerAlert #6904 rt Sep 8, 2023
@Libens-bufo Libens-bufo changed the title docs: add JSDoc to deprecate Alert in favor of BannerAlert #6904 rt docs: add JSDoc to deprecate Alert in favor of BannerAlert #6904 Sep 8, 2023
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution @Libens-bufo 🙏

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Mobile label Sep 18, 2023
@georgewrmarshall georgewrmarshall merged commit e28a071 into MetaMask:main Oct 24, 2023
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor team-design-system All issues relating to design system in Mobile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate Alert in favor of BannerAlert
2 participants