chore: Remove unused getNetworkName utility function
#7184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This `getNetworkName` utility function was not used. It has been removed to simplify the process of updating the network controller. Relates to MetaMask/mobile-planning#1226
Gudahtt
added
needs-dev-review
Gudahtt
added
the
No QA Needed
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #7184 +/- ##
==========================================
- Coverage 32.94% 32.94% -0.01%
==========================================
Files 1005 1005
Lines 32642 32640 -2
Branches 8383 8383
==========================================
- Hits 10755 10753 -2
Misses 21887 21887
☔ View full report in Codecov by Sentry. |
|
Passing E2E smoke test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/502a69b7-fd38-4cab-a01f-20b2bc4cee39 |
Gudahtt
removed
the
needs-dev-review
metamaskbot
added
the
release-7.8.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qa: PR requires manual QA.No QA/E2E only: PR does not require any manual QA effort. Prior to merging, ensure that you have successful end-to-end test runs in Bitrise.Spot check on release build: PR does not require feature QA but needs non-automated verification. In the description section, provide test scenarios. Add screenshots, and or recordings of what was tested.QA Passedlabel when QA has signed off (Only required if the PR was labeled withneeds-qa)team-(orexternal-contributorlabel if your not a MetaMask employee)Description
This
getNetworkNameutility function was not used. It has been removed to simplify the process of updating the network controller.Issue
Relates to https://github.com/MetaMask/mobile-planning/issues/1226
Checklist