Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sonar coverage path #7187

Merged
merged 20 commits into from
Sep 15, 2023
Merged

fix: sonar coverage path #7187

merged 20 commits into from
Sep 15, 2023

Conversation

sethkfman
Copy link
Contributor

@sethkfman sethkfman commented Sep 8, 2023

Description

This PR fixes the path for sonar coverage.

PR example of working coverage

Test PR showing coverage being reported: #7214

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@sethkfman sethkfman requested a review from a team as a code owner September 8, 2023 21:25
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Gudahtt
Gudahtt previously approved these changes Sep 8, 2023
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, good catch!

@Gudahtt
Copy link
Member

Gudahtt commented Sep 8, 2023

Actually... not sure if this will work. That entry is still for lcov, which is a different report format

@sethkfman
Copy link
Contributor Author

@Gudahtt I am updating to generate the lcov file

@Gudahtt
Copy link
Member

Gudahtt commented Sep 11, 2023

Found the docs: https://docs.sonarcloud.io/enriching/test-coverage/javascript-typescript-test-coverage/
Wasn't aware that SonarCloud only supported lcov, sorry about that! Good to know.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.12% ⚠️

Comparison is base (1585519) 33.14% compared to head (e282855) 33.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7187      +/-   ##
==========================================
- Coverage   33.14%   33.02%   -0.12%     
==========================================
  Files        1005     1004       -1     
  Lines       32649    26885    -5764     
  Branches     8398     2130    -6268     
==========================================
- Hits        10823     8880    -1943     
+ Misses      21826    17569    -4257     
- Partials        0      436     +436     

see 671 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sonar-project.properties Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@sethkfman
Copy link
Contributor Author

@Gudahtt Okay, I have a linked test PR in the description showing a 0% coverage reporting on new code. That should be the evidence we need to move forward with this PR.

@sethkfman sethkfman added the No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. label Sep 15, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sethkfman sethkfman added the release-7.8.0 Issue or pull request that will be included in release 7.8.0 label Sep 15, 2023
@sethkfman sethkfman merged commit 31744a1 into main Sep 15, 2023
26 checks passed
@sethkfman sethkfman deleted the fix/sonar-test-coverage branch September 15, 2023 21:35
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.8.0 Issue or pull request that will be included in release 7.8.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants