-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sonar coverage path #7187
fix: sonar coverage path #7187
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, good catch!
Actually... not sure if this will work. That entry is still for lcov, which is a different report format |
@Gudahtt I am updating to generate the lcov file |
Found the docs: https://docs.sonarcloud.io/enriching/test-coverage/javascript-typescript-test-coverage/ |
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #7187 +/- ##
==========================================
- Coverage 33.14% 33.02% -0.12%
==========================================
Files 1005 1004 -1
Lines 32649 26885 -5764
Branches 8398 2130 -6268
==========================================
- Hits 10823 8880 -1943
+ Misses 21826 17569 -4257
- Partials 0 436 +436 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
@Gudahtt Okay, I have a linked test PR in the description showing a 0% coverage reporting on new code. That should be the evidence we need to move forward with this PR. |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR fixes the path for sonar coverage.
PR example of working coverage
Test PR showing coverage being reported: #7214
Checklist