Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bug #1238 preventing use of wallet_switchethereumchain #7200

Merged
merged 1 commit into from
Sep 12, 2023
Merged

fix: bug #1238 preventing use of wallet_switchethereumchain #7200

merged 1 commit into from
Sep 12, 2023

Conversation

abretonc7s
Copy link
Contributor

@abretonc7s abretonc7s commented Sep 12, 2023 •
edited by chrisleewilcox

@abretonc7s abretonc7s requested a review from a team as a code owner September 12, 2023 08:33
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@abretonc7s abretonc7s added the team-sdk SDK team label Sep 12, 2023
andreahaku
andreahaku approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abretonc7s abretonc7s added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Sep 12, 2023
@andreahaku andreahaku added the release-7.7.0 Issue or pull request that will be included in release 7.7.0 label Sep 12, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@chrisleewilcox chrisleewilcox added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Sep 12, 2023
@chrisleewilcox
Copy link
Contributor

Tested on Unity SDK....

https://recordit.co/cEJ8kSjxvV

@chrisleewilcox chrisleewilcox added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Sep 12, 2023
chrisleewilcox
chrisleewilcox approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisleewilcox chrisleewilcox merged commit 2fbafdf into main Sep 12, 2023
31 of 34 checks passed
@chrisleewilcox chrisleewilcox deleted the fix/wallet_switchethereumchain_1238 branch September 12, 2023 20:48
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2023
@metamaskbot metamaskbot added the release-7.8.0 Issue or pull request that will be included in release 7.8.0 label Sep 12, 2023
@chrisleewilcox chrisleewilcox removed the release-7.7.0 Issue or pull request that will be included in release 7.7.0 label Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisleewilcox chrisleewilcox chrisleewilcox approved these changes

@andreahaku andreahaku andreahaku approved these changes

Assignees

@andreahaku andreahaku

Labels
QA Passed A successful QA run through has been done release-7.8.0 Issue or pull request that will be included in release 7.8.0 team-sdk SDK team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@abretonc7s @chrisleewilcox @andreahaku @metamaskbot