Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: 939 e2e migrate senderc20 test to detox #7207

Merged
merged 13 commits into from
Sep 25, 2023

Conversation

sleepytanya
Copy link
Contributor

@sleepytanya sleepytanya commented Sep 13, 2023

Description
Draft PR
_This PR migrates 'Send ERC20 Token' test to Detox.

Screenshots/Recordings
iOS 'send-ERC721' test:
Mac_ok_721
iOS 'send-ERC20' test:
Mac_ok_20

'send-ERC721' on Android:

And_ok_721 'send-ERC20' test on Android: And_0k_20

fixes 1308

Bitrise run.
Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@sleepytanya sleepytanya self-assigned this Sep 13, 2023
@sleepytanya sleepytanya requested a review from a team as a code owner September 13, 2023 02:46
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sleepytanya sleepytanya changed the title 939 e2e migrate senderc20 test to detox test: 939 e2e migrate senderc20 test to detox Sep 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0afaaa8) 34.60% compared to head (359d59d) 34.60%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7207   +/-   ##
=======================================
  Coverage   34.60%   34.60%           
=======================================
  Files        1016     1016           
  Lines       27107    27107           
  Branches     2198     2198           
=======================================
  Hits         9381     9381           
  Misses      17237    17237           
  Partials      489      489           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sleepytanya sleepytanya added team-confirmations-system DEPRECATED: please use "team-confirmations" label instead E2E needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Sep 16, 2023
@sleepytanya sleepytanya removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 25, 2023
@sleepytanya sleepytanya added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 25, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sleepytanya sleepytanya merged commit b3a7de4 into main Sep 25, 2023
24 checks passed
@sleepytanya sleepytanya deleted the 939-e2e-migrate-senderc20-test-to-detox branch September 25, 2023 14:34
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E2E release-7.9.0 team-confirmations-system DEPRECATED: please use "team-confirmations" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants