Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2e:Parallel execution support for Android in Bitrise CI #7216

Merged
merged 11 commits into from
Sep 15, 2023

Conversation

Andepande
Copy link
Member

@Andepande Andepande commented Sep 13, 2023

Description

  • Updated Bitrise.yml to enable parallel Android test execution in Bitrise CI pipelines
  • Reduced test run time from ~55 mins to ~40 with 3 workers running in parallel reducing in turn reducing bitrise credit consumption

Screenshots/Recordings

https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fe85a5da-38dd-471b-a5c3-52c872afb4bd

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@Andepande Andepande requested a review from a team as a code owner September 13, 2023 21:00
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Andepande Andepande changed the title [E2e] - Parallel execution support for Android in Bitrise CI E2e:Parallel execution support for Android in Bitrise CI Sep 13, 2023
@Andepande Andepande linked an issue Sep 13, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4fd873a) 33.14% compared to head (bb26ad7) 33.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7216   +/-   ##
=======================================
  Coverage   33.14%   33.14%           
=======================================
  Files        1005     1005           
  Lines       32658    32658           
  Branches     8398     8398           
=======================================
  Hits        10826    10826           
  Misses      21832    21832           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SamuelSalas
SamuelSalas previously approved these changes Sep 14, 2023
@SamuelSalas
Copy link
Member

LGTM

Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀🚀🌑

@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
react-native-splash-screen 3.2.0 None +1 277 kB crazycodeboy

@socket-security
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Network access appium-remote-debugger 5.7.0
Network access appium-remote-debugger 8.13.2
New author appium-remote-debugger 8.13.2
Unmaintained opencv-bindings 4.5.5
  • Last Publish: 11/6/2021, 12:45:37 AM
Unmaintained react-native-splash-screen 3.2.0
  • Last Publish: 12/7/2021, 5:32:39 AM

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What are unmaintained packages?

Package has not been updated in more than a year and may be unmaintained. Problems with the package may go unaddressed.

Package should publish periodic maintenance releases if they are maintained, or deprecate if they have no intention in further maintenance.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore appium-remote-debugger@8.13.2
  • @SocketSecurity ignore appium-remote-debugger@5.7.0
  • @SocketSecurity ignore opencv-bindings@4.5.5
  • @SocketSecurity ignore react-native-splash-screen@3.2.0

@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Andepande Andepande merged commit dd025c1 into main Sep 15, 2023
23 of 24 checks passed
@Andepande Andepande deleted the android-parallel-e2e-test-linux-b branch September 15, 2023 08:06
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 15, 2023
@metamaskbot metamaskbot added the release-7.8.0 Issue or pull request that will be included in release 7.8.0 label Sep 15, 2023
@gauthierpetetin gauthierpetetin added team-mobile-platform team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead labels Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.8.0 Issue or pull request that will be included in release 7.8.0 team-mobile-platform team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run appium test in parallel with multiple devices
8 participants