Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: all regex in one file #7217

Merged
merged 21 commits into from
Sep 25, 2023
Merged

fix: all regex in one file #7217

merged 21 commits into from
Sep 25, 2023

Conversation

frankvonhoven
Copy link
Contributor

@frankvonhoven frankvonhoven commented Sep 13, 2023 •
edited

Description

Consolidates regular expressions throughout the codeabase into a single file

Issue

fixes #6684

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@frankvonhoven frankvonhoven changed the title fix: all regex in one file as object - few tweaks still needed fix: all regex in one file Sep 14, 2023
@frankvonhoven frankvonhoven added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Sep 14, 2023
@frankvonhoven frankvonhoven marked this pull request as ready for review September 14, 2023 23:54
@frankvonhoven frankvonhoven requested a review from a team as a code owner September 14, 2023 23:54
@sethkfman
Copy link
Contributor

@frankvonhoven It looks like you have a few broken tests. Please resolve and I will take a look.

sethkfman
sethkfman reviewed Sep 19, 2023
View reviewed changes
app/util/regex/index.ts Outdated Show resolved Hide resolved
sethkfman
sethkfman reviewed Sep 19, 2023
View reviewed changes
app/util/regex/index.ts Outdated Show resolved Hide resolved
sethkfman
sethkfman reviewed Sep 19, 2023
View reviewed changes
app/util/regex/index.ts Outdated Show resolved Hide resolved
@gauthierpetetin gauthierpetetin added in-progress needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) in-progress labels Sep 20, 2023
sethkfman
sethkfman previously approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look good to me. Let me know if you need support with the unit testing.

@frankvonhoven
Copy link
Contributor Author

Updates look good to me. Let me know if you need support with the unit testing.

@sethkfman I do!

@sethkfman
Copy link
Contributor

E2E Test: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/61b9886d-5ae4-4717-b2db-c8587c5c7128

@sonarcloud
Copy link

sonarcloud bot commented Sep 25, 2023 •
edited

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

45.5% 45.5% Coverage
2.2% 2.2% Duplication

sethkfman
sethkfman approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frankvonhoven frankvonhoven added release-7.9.0 and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Sep 25, 2023
@frankvonhoven frankvonhoven merged commit 481412d into main Sep 25, 2023
26 checks passed
@frankvonhoven frankvonhoven deleted the fix/6684-all-regex-in-single-file branch September 25, 2023 22:10
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2023
@gauthierpetetin gauthierpetetin added team-mobile-platform team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead labels Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.9.0 team-mobile-platform team-mobile-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@frankvonhoven @sethkfman @gauthierpetetin