Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove linea mainnet feature toggle #7223

Merged
merged 5 commits into from
Sep 21, 2023

Conversation

VGau
Copy link
Contributor

@VGau VGau commented Sep 14, 2023

Description

  • Removed Linea mainnet feature toggle and related functions and conditions
  • Removed Linea mainnet not released warning message

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

fixes #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@VGau VGau added the team-linea Linea team label Sep 14, 2023
@VGau VGau requested a review from a team as a code owner September 14, 2023 16:08
@VGau VGau changed the title Fix/remove linea mainnet feature toggle fix: remove linea mainnet feature toggle Sep 14, 2023
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman added the release-7.8.0 Issue or pull request that will be included in release 7.8.0 label Sep 14, 2023
@sethkfman
Copy link
Contributor

sethkfman commented Sep 14, 2023

@VGau VGau force-pushed the fix/remove-linea-mainnet-feature-toggle branch from 320c8c7 to 348ca4a Compare September 14, 2023 16:11
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (ad9793b) 34.43% compared to head (55eb86e) 34.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7223      +/-   ##
==========================================
- Coverage   34.43%   34.43%   -0.01%     
==========================================
  Files        1016     1016              
  Lines       27089    27066      -23     
  Branches     2206     2204       -2     
==========================================
- Hits         9329     9321       -8     
+ Misses      17267    17253      -14     
+ Partials      493      492       -1     
Files Changed Coverage Δ
app/components/Nav/Main/index.js 7.37% <ø> (+0.66%) ⬆️
...mponents/Views/NetworkSelector/NetworkSelector.tsx 63.33% <ø> (-1.82%) ⬇️
...omponents/Views/Settings/NetworksSettings/index.js 3.80% <ø> (+0.07%) ⬆️
app/constants/urls.ts 100.00% <ø> (ø)
app/util/networks/index.js 75.38% <ø> (-0.38%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sethkfman sethkfman added the No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. label Sep 15, 2023
@sethkfman
Copy link
Contributor

sethkfman commented Sep 15, 2023

@chrisleewilcox chrisleewilcox removed the release-7.8.0 Issue or pull request that will be included in release 7.8.0 label Sep 20, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman merged commit 08928ce into main Sep 21, 2023
25 checks passed
@sethkfman sethkfman deleted the fix/remove-linea-mainnet-feature-toggle branch September 21, 2023 21:15
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.9.0 team-linea Linea team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants