feat: Add header to watch asset page #7261
Merged
+24
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segun
added
needs-dev-review
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
segun
force-pushed
the
olu/header-origin-watch-asset
branch
from
19dd7d8
to
03ff381
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #7261 +/- ##
==========================================
- Coverage 33.02% 33.02% -0.01%
==========================================
Files 1004 1004
Lines 26888 26890 +2
Branches 2131 2131
==========================================
Hits 8881 8881
- Misses 17571 17573 +2
Partials 436 436
☔ View full report in Codecov by Sentry. |
bschorchit
removed
the
team-confirmations-secure-ux
segun
changed the title
jpuri
approved these changes
Sep 22, 2023
|
Hey @segun : I just noticed that new header is showing balance in new asset which is being added. Is that expected behaviour ? |
blackdevelopa
approved these changes
Sep 26, 2023
github-actions
bot
removed
the
needs-dev-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Display the header and origin pill on the wallet_watchAsset confirmation page.
Screenshots/Recordings
Before
After
Issue
See #6620
Checklist