Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade Mobile Storybook to version 6.5 #7263

Merged
merged 14 commits into from
Sep 22, 2023
Merged

Conversation

brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Sep 19, 2023

Description

  • Upgrade Mobile Storybook to version 6.5
  • Currently only uses samples story as a sample

Screenshots/Recordings

Simulator Screen Shot - iPhone 14 Pro - 2023-09-21 at 11 56 33
Simulator Screen Shot - iPhone 14 Pro - 2023-09-21 at 11 56 32
Simulator Screen Shot - iPhone 14 Pro - 2023-09-21 at 11 56 30

Related issues

Fixes #???

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-design-system All issues relating to design system in Mobile labels Sep 19, 2023
@brianacnguyen brianacnguyen self-assigned this Sep 19, 2023
@brianacnguyen brianacnguyen requested a review from a team as a code owner September 19, 2023 02:39
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@brianacnguyen brianacnguyen added the Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking label Sep 19, 2023
@brianacnguyen brianacnguyen changed the title Upgrade Mobile Storybook to version 6.5 feat: Upgrade Mobile Storybook to version 6.5 Sep 19, 2023
@socket-security
Copy link

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@storybook/addon-ondevice-controls 6.5.6 None +41 16.1 MB dannyhw
@react-native-community/slider 4.4.3 None +0 253 kB bartoszklonowski
@storybook/addon-ondevice-actions 5.3.23...6.5.6 None +22/-6 13.8 MB dannyhw
react-native-safe-area-context 3.2.0...4.7.2 environment +5/-1 1.19 MB janicduplessis
@storybook/react-native 5.3.25...6.5.6 None +38/-4 16.1 MB dannyhw

🚮 Removed packages: @storybook/addon-actions@5.3.21

@socket-security
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Bin script confusion @storybook/semver 7.3.2
Unmaintained @storybook/semver 7.3.2
  • Last Publish: 5/26/2020, 9:23:30 AM
Bin script confusion semver 4.3.6
Bin script confusion semver 5.3.0
Bin script confusion semver 5.4.1
Bin script confusion semver 5.7.1
Bin script confusion semver 6.3.0
Bin script confusion semver 6.3.1
Bin script confusion semver 7.3.7
Bin script confusion semver 7.5.0
Bin script confusion semver 7.5.4
CVE prismjs 1.17.1
Mild CVE prismjs 1.17.1
Deprecated highlight.js 9.18.5
  • Reason: Support has ended for 9.x series. Upgrade to @latest
Mild CVE highlight.js 9.18.5
Deprecated highlight.js 9.13.1
  • Reason: Version no longer supported. Upgrade to @latest
Mild CVE highlight.js 9.13.1
Network access @storybook/api 6.5.16
Network access @storybook/core-client 6.5.16
Network access @storybook/preview-web 6.5.16
Network access esbuild 0.18.20
Shell access esbuild 0.18.20
New author react-inspector 5.1.1
Unmaintained select 1.1.2
  • Last Publish: 2/8/2017, 7:25:34 AM
Unmaintained globalthis 1.0.3
  • Last Publish: 5/7/2022, 3:51:20 PM
Unmaintained tiny-emitter 2.1.0
  • Last Publish: 2/5/2019, 3:40:52 PM
Unmaintained clipboard 2.0.11
  • Last Publish: 5/4/2022, 6:01:40 PM
Unmaintained good-listener 1.2.2
  • Last Publish: 2/28/2017, 5:56:06 PM
Unmaintained app-root-dir 1.0.2
  • Last Publish: 5/28/2015, 3:51:58 PM
Unmaintained ansi-to-html 0.6.15
  • Last Publish: 10/5/2021, 12:44:50 AM
Unmaintained @babel/plugin-syntax-private-property-in-object 7.14.5
  • Last Publish: 6/9/2021, 11:11:53 PM

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

ios/Podfile.lock Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2023

Codecov Report

Patch coverage: 20.00% and project coverage change: +0.01% 🎉

Comparison is base (08928ce) 34.43% compared to head (b3ff956) 34.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7263      +/-   ##
==========================================
+ Coverage   34.43%   34.45%   +0.01%     
==========================================
  Files        1016     1016              
  Lines       27066    27059       -7     
  Branches     2204     2204              
==========================================
+ Hits         9321     9322       +1     
+ Misses      17253    17245       -8     
  Partials      492      492              
Files Changed Coverage Δ
...anner/variants/BannerAlert/BannerAlert.stories.tsx 0.00% <0.00%> (ø)
...ent-library/components/Cards/Card/Card.stories.tsx 0.00% <0.00%> (ø)
...nner/variants/BannerAlert/BannerAlert.constants.ts 81.81% <100.00%> (+1.81%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
ios/Podfile.lock Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

20.0% 20.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 22, 2023
@brianacnguyen brianacnguyen merged commit a36d4e4 into main Sep 22, 2023
25 checks passed
@brianacnguyen brianacnguyen deleted the morph/storybook branch September 22, 2023 05:23
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.9.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants