-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logging controller #7273
Add logging controller #7273
Conversation
4249586
to
8e39d95
Compare
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Do we also need to ensure the state changes are detected by Redux by updating the |
Sorry missed that, added in 543d8d7 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #7273 +/- ##
=======================================
Coverage 34.43% 34.43%
=======================================
Files 1016 1016
Lines 27087 27088 +1
Branches 2206 2206
=======================================
+ Hits 9327 9328 +1
- Misses 17267 17269 +2
+ Partials 493 491 -2
☔ View full report in Codecov by Sentry. |
543d8d7
to
de56283
Compare
Kudos, SonarCloud Quality Gate passed! |
Description
This PR aims to add and initiate LoggingController which will be used in the SignatureController in subsequent PR.
Manual testing steps
There are no functional changes, no need for manual testing.
Related issues
Fixing https://github.com/MetaMask/mobile-planning/issues/1256
Pre-merge author checklist
Pre-merge reviewer checklist