Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging controller #7273

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Sep 20, 2023

Description

This PR aims to add and initiate LoggingController which will be used in the SignatureController in subsequent PR.

Manual testing steps

There are no functional changes, no need for manual testing.

Related issues

Fixing https://github.com/MetaMask/mobile-planning/issues/1256

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz added the team-confirmations-system DEPRECATED: please use "team-confirmations" label instead label Sep 20, 2023
@OGPoyraz OGPoyraz force-pushed the 1256-create-logging-controller-instance-in-mobile branch 5 times, most recently from 4249586 to 8e39d95 Compare September 20, 2023 11:09
@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/logging-controller 1.0.1 None +0 24.3 kB metamaskbot

@OGPoyraz OGPoyraz marked this pull request as ready for review September 20, 2023 11:23
@OGPoyraz OGPoyraz requested a review from a team as a code owner September 20, 2023 11:23
@matthewwalsh0
Copy link
Member

Do we also need to ensure the state changes are detected by Redux by updating the updateControllers method in EngineService?

@OGPoyraz
Copy link
Member Author

OGPoyraz commented Sep 20, 2023

Do we also need to ensure the state changes are detected by Redux by updating the updateControllers method in EngineService?

Sorry missed that, added in 543d8d7

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5b0177c) 34.43% compared to head (de56283) 34.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7273   +/-   ##
=======================================
  Coverage   34.43%   34.43%           
=======================================
  Files        1016     1016           
  Lines       27087    27088    +1     
  Branches     2206     2206           
=======================================
+ Hits         9327     9328    +1     
- Misses      17267    17269    +2     
+ Partials      493      491    -2     
Files Changed Coverage Δ
app/core/EngineService/EngineService.ts 82.05% <ø> (ø)
app/core/Engine.ts 53.94% <100.00%> (+0.20%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OGPoyraz OGPoyraz force-pushed the 1256-create-logging-controller-instance-in-mobile branch from 543d8d7 to de56283 Compare September 21, 2023 06:35
@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@OGPoyraz OGPoyraz merged commit 8832ce7 into main Sep 22, 2023
24 checks passed
@OGPoyraz OGPoyraz deleted the 1256-create-logging-controller-instance-in-mobile branch September 22, 2023 04:29
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.9.0 team-confirmations-system DEPRECATED: please use "team-confirmations" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants