fix: handle overlapping add network requests

[matthewwalsh0]

Description

When adding a network, an approval flow is used to ensure the modal remains visible while showing both the add network and switch network confirmations.

Currently if two add network approval requests exist at the same time, the first is rejected by the second however this leaves the associated approval flow of the first open as it cannot be ended since it is a parent to the second approval flow. This results in the first approval flow persisting until restart causing an infinite loader to be shown.

This PR resolves this scenario by clearing all pending approval requests before creating the approval flow which in turn ends their associated approval flows.

Manual Testing Steps

1. Go to chainlist.network.
2. Double click when adding any new network.
3. Approve the add network confirmation.
4. Approve the switch network confirmation.
5. Ensure no infinite loader or confirmation is visible.

Recordings

add_network_overlap.mov

Related Issues

Fixes #7259

Pre-merge Author Checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained:
  • What problem this PR is solving.
  • How this problem was solved.
  • How reviewers can test my changes.
• I’ve indicated what issue this PR is linked to: Fixes #???
• I’ve included tests if applicable.
• I’ve documented any added code.
• I’ve applied the right labels on the PR (see labeling guidelines).
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge Reviewer Checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

[sleepytanya]

Works as expected:

Screen.Recording.2023-09-20.at.12.28.25.PM.mov

[matthewwalsh0]

Bitrise Report