Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Add accessibilityRole to text component #7324

Merged
merged 3 commits into from
Sep 25, 2023
Merged

refactor: Add accessibilityRole to text component #7324

merged 3 commits into from
Sep 25, 2023

Conversation

brianacnguyen
Copy link
Contributor

Description

  • Added accessibilityRole to text component
  • Updated affected snapshots

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile labels Sep 25, 2023
@brianacnguyen brianacnguyen requested a review from a team as a code owner September 25, 2023 20:24
@brianacnguyen brianacnguyen self-assigned this Sep 25, 2023
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@brianacnguyen brianacnguyen changed the title Add accessibilityRole to text component refactor: Add accessibilityRole to text component Sep 25, 2023
owencraston
owencraston previously approved these changes Sep 25, 2023
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented Sep 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@brianacnguyen brianacnguyen merged commit 7c368d1 into main Sep 25, 2023
24 checks passed
@brianacnguyen brianacnguyen deleted the morph/text-accessibility branch September 25, 2023 21:32
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@owencraston owencraston owencraston approved these changes

Assignees

@brianacnguyen brianacnguyen

Labels
release-7.9.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brianacnguyen @owencraston @metamaskbot