Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update Header and convert Header Story #7326

Merged
merged 9 commits into from
Oct 25, 2023

Conversation

brianacnguyen
Copy link
Contributor

Description

  • Renamed Header to HeaderBase to align with Figma (link)
  • Moved padding from HeaderBase to BottomSheetHeader
  • Converted story to v6.5
  • Updated tests

Screenshots/Recordings

Simulator Screen Shot - iPhone 14 Pro - 2023-09-25 at 15 02 32
Simulator Screen Shot - iPhone 14 Pro - 2023-09-25 at 15 02 34

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile labels Sep 25, 2023
@brianacnguyen brianacnguyen requested a review from a team as a code owner September 25, 2023 23:26
@brianacnguyen brianacnguyen self-assigned this Sep 25, 2023
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (7f46d2b) 34.85% compared to head (f605bca) 34.85%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7326   +/-   ##
=======================================
  Coverage   34.85%   34.85%           
=======================================
  Files        1027     1027           
  Lines       27423    27423           
  Branches     2267     2267           
=======================================
  Hits         9558     9558           
  Misses      17355    17355           
  Partials      510      510           
Files Coverage Δ
...eets/BottomSheetHeader/BottomSheetHeader.styles.ts 100.00% <ø> (ø)
...ttomSheets/BottomSheetHeader/BottomSheetHeader.tsx 60.00% <ø> (ø)
...rary/components/HeaderBase/HeaderBase.constants.ts 100.00% <100.00%> (ø)
...library/components/HeaderBase/HeaderBase.styles.ts 57.14% <100.00%> (ø)
...onent-library/components/HeaderBase/HeaderBase.tsx 100.00% <100.00%> (ø)
...brary/components/HeaderBase/HeaderBase.stories.tsx 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A couple non-blocking comments

Do we want to add any more example stories here and or controls?

@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

69.0% 69.0% Coverage
0.0% 0.0% Duplication

@brianacnguyen brianacnguyen merged commit af2a404 into main Oct 25, 2023
25 checks passed
@brianacnguyen brianacnguyen deleted the morph/update-header branch October 25, 2023 20:48
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 25, 2023
@metamaskbot metamaskbot added the release-7.11.0 Issue or pull request that will be included in release 7.11.0 label Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.11.0 Issue or pull request that will be included in release 7.11.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants