Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Convert Banner stories to csf format #7329

Merged
merged 10 commits into from
Nov 17, 2023
Merged

refactor: Convert Banner stories to csf format #7329

merged 10 commits into from
Nov 17, 2023

Conversation

brianacnguyen
Copy link
Contributor

Description

  • Convert Banner Alert story to csf format
  • Convert Banner Tip story to csf format
  • Convert Banner story to csf format

Screenshots/Recordings

Simulator Screen Shot - iPhone 14 Pro - 2023-09-25 at 21 16 30
Simulator Screen Shot - iPhone 14 Pro - 2023-09-25 at 21 16 36
Simulator Screen Shot - iPhone 14 Pro - 2023-09-25 at 21 16 38
Simulator Screen Shot - iPhone 14 Pro - 2023-09-25 at 21 16 43

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile labels Sep 26, 2023
@brianacnguyen brianacnguyen requested a review from a team as a code owner September 26, 2023 04:19
@brianacnguyen brianacnguyen self-assigned this Sep 26, 2023
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023 •
edited

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (233d123) 35.09% compared to head (201ff3d) 35.10%.

Files Patch % Lines
...brary/components/Banners/Banner/Banner.stories.tsx 0.00% 3 Missing ⚠️
...rs/Banner/variants/BannerTip/BannerTip.stories.tsx 0.00% 3 Missing ⚠️
...rary/components/Banners/Banner/Banner.constants.ts 66.66% 2 Missing ⚠️
...anner/variants/BannerAlert/BannerAlert.stories.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7329      +/-   ##
==========================================
+ Coverage   35.09%   35.10%   +0.01%     
==========================================
  Files        1040     1040              
  Lines       27663    27659       -4     
  Branches     2342     2342              
==========================================
+ Hits         9707     9711       +4     
+ Misses      17431    17423       -8     
  Partials      525      525

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

30.8% 30.8% Coverage
0.0% 0.0% Duplication

georgewrmarshall
georgewrmarshall previously approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A couple non-blocking comments that might be worth investigation.

  • pulled branch checked stories and controls

When I edit the actionButtonProps.variant controls it breaks storybook

error.mov

Console error to be aware of

Screenshot 2023-10-12 at 12 35 02 PM

app/component-library/components/Banners/Banner/variants/BannerTip/BannerTip.stories.tsx Outdated Show resolved Hide resolved
@brianacnguyen
Copy link
Contributor Author

LGTM! A couple non-blocking comments that might be worth investigation.

  • pulled branch checked stories and controls

When I edit the actionButtonProps.variant controls it breaks storybook

error.mov
Console error to be aware of

Screenshot 2023-10-12 at 12 35 02 PM

fixed

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

26.7% 26.7% Coverage
0.0% 0.0% Duplication

@brianacnguyen brianacnguyen merged commit f1cb516 into main Nov 17, 2023
26 checks passed
@brianacnguyen brianacnguyen deleted the morph/convert-banner branch November 17, 2023 01:43
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 17, 2023
@metamaskbot metamaskbot added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@georgewrmarshall georgewrmarshall georgewrmarshall approved these changes

Assignees

@brianacnguyen brianacnguyen

Labels
release-7.12.0 Issue or pull request that will be included in release 7.12.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brianacnguyen @codecov-commenter @georgewrmarshall @metamaskbot