Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update linea goerli explorer url #7338

Merged
merged 3 commits into from
Nov 22, 2023
Merged

fix: update linea goerli explorer url #7338

merged 3 commits into from
Nov 22, 2023

Conversation

VGau
Copy link
Contributor

@VGau VGau commented Sep 26, 2023 •
edited

Description

Updated Linea Goerli explorer url.

  • Replaced https://explorer.goerli.linea.build with https://goerli.lineascan.build.
  • Created a new @metamask/controller-utils patch

Manual testing steps

1. Step1: Send a transaction using the Linea Goerli network
2. Step2: Open the transaction description
3. Step3: Click on the "View on Etherscan" button
4. Step4: Check that it redirects to https://goerli.lineascan.build

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change.

Before

[screenshot]

After

[screenshot]

Related issues

Patch related to Core PR MetaMask/core#1666

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@VGau VGau added the team-linea Linea team label Sep 26, 2023
@VGau VGau requested a review from a team as a code owner September 26, 2023 17:46
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@VGau VGau mentioned this pull request Sep 26, 2023
Closed
14 tasks
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (756209b) 37.39% compared to head (5b653e8) 37.39%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7338   +/-   ##
=======================================
  Coverage   37.39%   37.39%           
=======================================
  Files        1052     1052           
  Lines       28175    28175           
  Branches     2517     2517           
=======================================
  Hits        10536    10536           
  Misses      17040    17040           
  Partials      599      599

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NicolasMassart NicolasMassart added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Sep 28, 2023
NicolasMassart pushed a commit to MetaMask/core that referenced this pull request Sep 28, 2023
@VGau
fix: update linea goerli explorer url (#1666)
aa5ab03 
## Explanation

Update of Linea network Goerli explorer url.

## References

See also the [matching patch PR in mobile app](MetaMask/metamask-mobile#7338).

## Changelog

### `@metamask/network-controller`

- **CHANGED**: update of Linea network Goerli explorer url.

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
@sleepytanya
Copy link
Contributor

Linea Goerli explorer URL works as expected for me:

goerli_linea.mov

MajorLift pushed a commit to MetaMask/core that referenced this pull request Oct 11, 2023
@VGau @MajorLift
fix: update linea goerli explorer url (#1666)
55c0df7 
## Explanation

Update of Linea network Goerli explorer url.

## References

See also the [matching patch PR in mobile app](MetaMask/metamask-mobile#7338).

## Changelog

### `@metamask/network-controller`

- **CHANGED**: update of Linea network Goerli explorer url.

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
MajorLift pushed a commit to MetaMask/core that referenced this pull request Oct 11, 2023
@VGau @MajorLift
fix: update linea goerli explorer url (#1666)
ae75134 
## Explanation

Update of Linea network Goerli explorer url.

## References

See also the [matching patch PR in mobile app](MetaMask/metamask-mobile#7338).

## Changelog

### `@metamask/network-controller`

- **CHANGED**: update of Linea network Goerli explorer url.

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sethkfman sethkfman added release-7.12.0 Issue or pull request that will be included in release 7.12.0 Run Smoke E2E and removed release-7.10.0 needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Nov 22, 2023
@github-actions GitHub Actions
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/01b0ad72-050c-40e6-bff4-c2099d01eeb0
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sethkfman sethkfman added the No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. label Nov 22, 2023
@sethkfman sethkfman merged commit 69c79df into main Nov 22, 2023
28 checks passed
@sethkfman sethkfman deleted the fix/update-linea-goerli-explorer-url branch November 22, 2023 19:16
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2023
@metamaskbot metamaskbot added the release-7.13.0 Issue or pull request that will be included in release 7.13.0 label Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NicolasMassart NicolasMassart NicolasMassart approved these changes

@digiwand digiwand digiwand approved these changes

@Woodpile37 Woodpile37 Woodpile37 approved these changes

Assignees
No one assigned
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.12.0 Issue or pull request that will be included in release 7.12.0 release-7.13.0 Issue or pull request that will be included in release 7.13.0 team-linea Linea team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@VGau @codecov-commenter @sleepytanya @NicolasMassart @digiwand @Woodpile37 @sethkfman @metamaskbot