test: revert ganache termination on fixtures

[seaona]

Description

This PR brings back ganache termination on withFixtures after discovering the root cause for the flaky tests.
Ganache termination was moved to hooks, because it seemed to help reduce the flaky tests, but now that we've discovered the real root cause of the problem, ganache termination can be moved back to fixtures, where it was.

There was a PR merged a couple of weeks ago which introduced maxWorkers: 3 on ci. This makes tests run in parallel but does not parallelize the environment, making all our servers using the same ports to collision and fail.To confirm the theory, in this branch I disabled maxWorkers and all Confirmations tests run successfully.
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8381384d-19f4-4b91-a259-4f5de572e264

Manual testing steps

Running all Confirmations test without parallelization.
Successful run here: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8381384d-19f4-4b91-a259-4f5de572e264

Screenshots/Recordings

Before

/

After

/

Related issues

Fixes https://github.com/MetaMask/mobile-planning/issues/1286

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained:
  • What problem this PR is solving.
  • How this problem was solved.
  • How reviewers can test my changes.
• I’ve indicated what issue this PR is linked to: Fixes #???
• I’ve included tests if applicable.
• I’ve documented any added code.
• I’ve applied the right labels on the PR (see labeling guidelines).
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information