Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary dependency patch on SignatureController #7355

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Sep 29, 2023

Description

This PR aims to remove unnecessary dependency patch in SignatureController (message-manager patch) and make SignatureController@4.0.1 patch a bit cleaner by putting a comment (which branch patch created from) and remove unnecessary changes.

Why message-manager patch is removed?

Since controller-utils is updated in to 3.4.0 in mobile repo, the patch made in the message-manager is became unnecessary because patched imports already been exported in 3.4.0.

What changed in the signature-controller patch?

Same exported enums were needed in the signature-controller, so these patches are removed.
Also put a comment of how can we reproduce signature-controller patch if needed. https://github.com/MetaMask/core/tree/patch/mobile-signature-controller

Manual testing steps

No functional change here.
But it's still beneficial to run regression tests around signatures.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change.

Before

[screenshot]

After

[screenshot]

Related issues

Fixes #???

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz requested a review from a team as a code owner September 29, 2023 08:47
@OGPoyraz OGPoyraz changed the title Remove unnecessary dependency patch on signature controller Remove unnecessary dependency patch on SignatureController Sep 29, 2023
@OGPoyraz OGPoyraz added the team-confirmations-system DEPRECATED: please use "team-confirmations" label instead label Sep 29, 2023
@OGPoyraz OGPoyraz force-pushed the remove-signature-controller-dependency-patch branch from be29669 to 50342e1 Compare September 29, 2023 09:01
vinistevam
vinistevam previously approved these changes Sep 29, 2023
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c865d3c) 34.60% compared to head (3180dd4) 34.59%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7355      +/-   ##
==========================================
- Coverage   34.60%   34.59%   -0.01%     
==========================================
  Files        1017     1017              
  Lines       27144    27150       +6     
  Branches     2205     2211       +6     
==========================================
  Hits         9393     9393              
- Misses      17262    17268       +6     
  Partials      489      489              

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sleepytanya
Copy link
Contributor

All regression signatures tests are passing both on iOS and Android.
Screenshot 2023-10-02 at 1 21 01 AM

@OGPoyraz OGPoyraz merged commit bab39f1 into main Oct 11, 2023
24 checks passed
@OGPoyraz OGPoyraz deleted the remove-signature-controller-dependency-patch branch October 11, 2023 09:20
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2023
@metamaskbot metamaskbot added the release-7.10.0 Issue or pull request that will be included in release 7.10.0 label Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.10.0 Issue or pull request that will be included in release 7.10.0 team-confirmations-system DEPRECATED: please use "team-confirmations" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants