-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrating ppom update tool into mobile build #7363
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
a305bfb
to
06b2ae5
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7363 +/- ##
=======================================
Coverage 34.65% 34.66%
=======================================
Files 1023 1023
Lines 27346 27345 -1
Branches 2242 2242
=======================================
Hits 9478 9478
+ Misses 17370 17369 -1
Partials 498 498
☔ View full report in Codecov by Sentry. |
@SocketSecurity ignore-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like couple bits in CI left to fix then we're good 2 go
It seems we have some conflicts on this PR. |
Kudos, SonarCloud Quality Gate passed! |
Description
Add ppom-view tool https://github.com/MetaMask/ppom-view. into metamask mobile to add generation
ppom.html.js
generation into mobile build.Manual testing steps
_1. Run mobile build
_2. Build should run smoothly
_3. Build should generate new
ppom.html.js
Related issues
_Fixes: MetaMask/MetaMask-planning#1362
Pre-merge author checklist
Pre-merge reviewer checklist