Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating ppom update tool into mobile build #7363

Merged
merged 41 commits into from
Oct 24, 2023
Merged

Integrating ppom update tool into mobile build #7363

merged 41 commits into from
Oct 24, 2023

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Sep 29, 2023

Description

Add ppom-view tool https://github.com/MetaMask/ppom-view. into metamask mobile to add generation ppom.html.js generation into mobile build.

Manual testing steps

_1. Run mobile build
_2. Build should run smoothly
_3. Build should generate new ppom.html.js

Related issues

_Fixes: MetaMask/MetaMask-planning#1362

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead labels Sep 29, 2023
@jpuri jpuri requested a review from a team as a code owner September 29, 2023 15:25
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link

socket-security bot commented Sep 29, 2023

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/ppom-validator 0.7.0 None +0 131 kB metamaskbot
binary-base64-loader 1.0.0 None +16 13.7 MB krakoi
@babel/preset-env 7.22.6 None +70 14.9 MB nicolo-ribaudo
html-inline-script-webpack-plugin 3.2.0 None +24 14.1 MB icelam
webpack 5.88.1 None +15 13.7 MB thelarkinn
raw-loader 4.0.2 None +16 13.7 MB evilebottnawi
babel-loader 9.1.2 None +35 22.9 MB nicolo-ribaudo

@socket-security
Copy link

socket-security bot commented Sep 29, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: semver@6.3.0, binary-base64-loader@1.0.0, @babel/traverse@7.22.6, domutils@2.8.0, @nicolo-ribaudo/semver-v6@6.3.3

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@jpuri jpuri marked this pull request as draft October 3, 2023 10:18
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (03bf584) 34.65% compared to head (12afdd5) 34.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7363   +/-   ##
=======================================
  Coverage   34.65%   34.66%           
=======================================
  Files        1023     1023           
  Lines       27346    27345    -1     
  Branches     2242     2242           
=======================================
  Hits         9478     9478           
+ Misses      17370    17369    -1     
  Partials      498      498           
Files Coverage Δ
...ents/UI/BlockaidBanner/BlockaidBanner.constants.ts 100.00% <ø> (ø)
...pp/components/UI/BlockaidBanner/BlockaidBanner.tsx 84.00% <100.00%> (ø)
app/core/Engine.ts 54.18% <ø> (+0.23%) ⬆️
app/lib/ppom/PPOMView.tsx 35.13% <0.00%> (ø)
app/lib/ppom/invoke-lib.ts 5.71% <0.00%> (ø)
app/util/blockaid/index.ts 83.33% <50.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpuri
Copy link
Contributor Author

jpuri commented Oct 3, 2023

@SocketSecurity ignore-all

@jpuri jpuri marked this pull request as ready for review October 3, 2023 14:13
scripts/postinstall.sh Outdated Show resolved Hide resolved
@jpuri jpuri requested review from naugtur and leotm October 5, 2023 09:20
Copy link
Contributor

@leotm leotm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like couple bits in CI left to fix then we're good 2 go

ppom/src/ppom.js Show resolved Hide resolved
@jpuri jpuri requested a review from segun October 19, 2023 15:11
segun
segun previously approved these changes Oct 19, 2023
@jpuri jpuri added team-confirmations-secure-ux-PR PR from the confirmations team and removed team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead labels Oct 20, 2023
@blackdevelopa
Copy link
Contributor

It seems we have some conflicts on this PR.

@jpuri jpuri requested a review from segun October 23, 2023 17:17
@jpuri
Copy link
Contributor Author

jpuri commented Oct 24, 2023

@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

@jpuri jpuri merged commit c8e30cd into main Oct 24, 2023
25 checks passed
@jpuri jpuri deleted the ppom_integration branch October 24, 2023 18:08
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 24, 2023
@metamaskbot metamaskbot added the release-7.11.0 Issue or pull request that will be included in release 7.11.0 label Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.11.0 Issue or pull request that will be included in release 7.11.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants