Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump Node to v16.20 #7364

Merged
merged 3 commits into from
Sep 29, 2023
Merged

chore: bump Node to v16.20 #7364

merged 3 commits into from
Sep 29, 2023

Conversation

gantunesr
Copy link
Member

No description provided.

@gantunesr
Copy link
Member Author

gantunesr commented Sep 29, 2023 •
edited

Executing E2E in here.

Edit: Failed

@gantunesr
Copy link
Member Author

gantunesr commented Sep 29, 2023 •
edited

Executing E2E in here.

Edit: Failed

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2023 •
edited

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2609bb5) 34.59% compared to head (dde7b65) 34.59%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7364   +/-   ##
=======================================
  Coverage   34.59%   34.59%           
=======================================
  Files        1017     1017           
  Lines       27150    27150           
  Branches     2211     2211           
=======================================
  Hits         9393     9393           
  Misses      17268    17268           
  Partials      489      489

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gantunesr
Copy link
Member Author

E2E Successful

@gantunesr gantunesr marked this pull request as ready for review September 29, 2023 17:02
@gantunesr gantunesr requested a review from a team as a code owner September 29, 2023 17:02
@gantunesr
Copy link
Member Author

Successful QA builds

@gantunesr gantunesr changed the title chore: Bump Node to v16.20 chore: bump Node to v16.20 Sep 29, 2023
sethkfman
sethkfman approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. team-accounts labels Sep 29, 2023
@gantunesr gantunesr merged commit 41357f7 into main Sep 29, 2023
26 of 27 checks passed
@gantunesr gantunesr deleted the chore/bump-node-v16.20 branch September 29, 2023 22:36
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.10.0 team-accounts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gantunesr @codecov-commenter @sethkfman @metamaskbot