Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(bitrise): trigger smoke test on every merge to main #7366

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

sethkfman
Copy link
Contributor

@sethkfman sethkfman commented Sep 29, 2023

Description

This PR adds a trigger to run the E2E smoke tests on every merge into main. This will help us identify PR that break e2e tests.

Manual testing steps

NA

Screenshots/Recordings

NA

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman marked this pull request as ready for review September 29, 2023 22:16
@sethkfman sethkfman requested a review from a team as a code owner September 29, 2023 22:16
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2609bb5) 34.59% compared to head (fe077f0) 34.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7366   +/-   ##
=======================================
  Coverage   34.59%   34.59%           
=======================================
  Files        1017     1017           
  Lines       27150    27150           
  Branches     2211     2211           
=======================================
  Hits         9393     9393           
  Misses      17268    17268           
  Partials      489      489           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sethkfman sethkfman merged commit a11ac4d into main Sep 29, 2023
24 checks passed
@sethkfman sethkfman deleted the chore/e2e-merge-main branch September 29, 2023 22:51
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants