Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(action): bug report creation was not working #7371

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

gauthierpetetin
Copy link
Contributor

@gauthierpetetin gauthierpetetin commented Oct 2, 2023

Description

The last step of the create-release-pr.yml workflow creates a release branch, which shall itself trigger another workflow: create-bug-report.yml. However, there is a security feature in Github that prevents workflows from triggering other workflows by default. The workaround is to use a personal access token (BUG_REPORT_TOKEN) instead of the default GITHUB_TOKEN for the checkout action.

Manual testing steps

Available in original PR: #6967

Screenshots/Recordings

Available in original PR: #6967

Before

[screenshot]

After

[screenshot]

Related issues

Fixes https://github.com/MetaMask/mobile-planning/issues/1184

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

The last step of the create-release-pr.yml workflow creates a release branch, which shall itself trigger another workflow: create-bug-report.yml. However, there is a security feature in Github that prevents workflows from triggering other workflows by default. The workaround is to use a personal access token (BUG_REPORT_TOKEN) instead of the default GITHUB_TOKEN for the checkout action.
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gauthierpetetin gauthierpetetin added the No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. label Oct 2, 2023
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (46b493b) 34.59% compared to head (2238b57) 34.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7371   +/-   ##
=======================================
  Coverage   34.59%   34.59%           
=======================================
  Files        1017     1017           
  Lines       27150    27150           
  Branches     2211     2211           
=======================================
  Hits         9393     9393           
  Misses      17268    17268           
  Partials      489      489           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gauthierpetetin gauthierpetetin merged commit 30e2693 into main Oct 2, 2023
30 checks passed
@gauthierpetetin gauthierpetetin deleted the fix/bug-report-creation branch October 2, 2023 14:08
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.10.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants