Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: reorg signatures tests to maximize efficiency #7372

Merged
merged 16 commits into from
Oct 4, 2023
Merged

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Oct 2, 2023

Description

In this PR we are splitting up the Signatures test into different files, in the same way we have on Extension:

  • eth-sign
  • personal-sign
  • typed-sign

This helps us run test faster since they can run in parallel: ~ 9 minutes faster in Android

Manual testing steps

Screenshots/Recordings

Before

Running all tests (Smoke + Confirmations)

image

After

Running all tests (Smoke + Confirmations)

image

Related issues

_Fixes https://github.com/MetaMask/MetaMask-planning/issues/1394

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8636b3e) 34.59% compared to head (acb0c98) 34.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7372   +/-   ##
=======================================
  Coverage   34.59%   34.59%           
=======================================
  Files        1017     1017           
  Lines       27150    27150           
  Branches     2211     2211           
=======================================
  Hits         9393     9393           
  Misses      17268    17268           
  Partials      489      489           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seaona seaona changed the base branch from test-reorg-dynamic-ports to main October 2, 2023 11:24
@seaona seaona added the team-confirmations-secure-ux-PR PR from the confirmations team label Oct 2, 2023
@seaona seaona self-assigned this Oct 2, 2023
@seaona seaona changed the base branch from main to test-reorg-dynamic-ports October 2, 2023 11:33
@seaona seaona marked this pull request as ready for review October 2, 2023 13:18
@seaona seaona requested a review from a team as a code owner October 2, 2023 13:18
@seaona seaona changed the base branch from test-reorg-dynamic-ports to main October 2, 2023 15:50
@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@seaona seaona merged commit 3f68403 into main Oct 4, 2023
26 checks passed
@seaona seaona deleted the test-reorg-signatures branch October 4, 2023 09:15
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants