-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: reorg signatures tests to maximize efficiency #7372
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
14 tasks
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7372 +/- ##
=======================================
Coverage 34.59% 34.59%
=======================================
Files 1017 1017
Lines 27150 27150
Branches 2211 2211
=======================================
Hits 9393 9393
Misses 17268 17268
Partials 489 489 ☔ View full report in Codecov by Sentry. |
Kudos, SonarCloud Quality Gate passed! |
vinistevam
approved these changes
Oct 4, 2023
jpuri
approved these changes
Oct 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR we are splitting up the Signatures test into different files, in the same way we have on Extension:
This helps us run test faster since they can run in parallel: ~ 9 minutes faster in Android
Manual testing steps
Screenshots/Recordings
Before
Running all tests (Smoke + Confirmations)
After
Running all tests (Smoke + Confirmations)
Related issues
_Fixes https://github.com/MetaMask/MetaMask-planning/issues/1394
Pre-merge author checklist
Pre-merge reviewer checklist