Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(podfile): add react-native-launch-arguments to podfile.lock #7377

Merged
merged 1 commit into from
Oct 4, 2023
Merged

fix(podfile): add react-native-launch-arguments to podfile.lock #7377

merged 1 commit into from
Oct 4, 2023

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Oct 3, 2023

Description

This PR adds react-native-launch-arguments pod to Podfile.lock. This dependency was introduced in #7356 but Podfile.lock was not updated.

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei requested a review from a team as a code owner October 3, 2023 21:36
@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wachunei wachunei merged commit 5dda6cb into main Oct 4, 2023
27 checks passed
@wachunei wachunei deleted the fix/react-native-launch-arguments-podfile-lock branch October 4, 2023 12:51
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vinistevam vinistevam vinistevam approved these changes

Assignees
No one assigned
Labels
release-7.10.0 team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wachunei @vinistevam @metamaskbot