Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add Dependabot missing team label #7386

Merged
merged 2 commits into from
Oct 5, 2023
Merged

fix: Add Dependabot missing team label #7386

merged 2 commits into from
Oct 5, 2023

Conversation

leotm
Copy link
Contributor

@leotm leotm commented Oct 4, 2023 •
edited

Description

All dependabot PRs currently failing CI due to

No team labels found

This simply fixes that ^

Presuming previous labels are being added automagically

  • dependencies
  • javascript

Manual testing steps

Re-trigger a dependabot PR
or wait for the next one

Screenshots/Recordings

N/A

Before

N/A

After

N/A

Related issues

N/A

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@leotm
Add Dependabot missing team label
b4dda53 
All currently breaking CI:
> No team labels found

Presuming previous labels
- dependencies
- javascript
Are being added automagically
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@leotm leotm marked this pull request as ready for review October 4, 2023 15:02
@leotm leotm requested a review from a team as a code owner October 4, 2023 15:02
leotm

This comment was marked as outdated.

Sign in to view

leotm
leotm commented Oct 4, 2023
View reviewed changes
.github/dependabot.yml Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2023 •
edited

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (d25c011) 34.59% compared to head (c7bcb09) 34.62%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7386      +/-   ##
==========================================
+ Coverage   34.59%   34.62%   +0.02%     
==========================================
  Files        1017     1017              
  Lines       27165    27157       -8     
  Branches     2215     2215              
==========================================
+ Hits         9397     9402       +5     
+ Misses      17278    17265      -13     
  Partials      490      490
Files Coverage Δ
app/components/Views/ResetPassword/index.js 6.15% <ø> (+0.27%) ⬆️
app/core/AppConstants.ts 80.00% <ø> (ø)
app/core/BackupVault/backupVault.ts 45.00% <ø> (ø)
app/core/EngineService/EngineService.ts 82.05% <ø> (ø)
app/util/mnemonic/index.ts 100.00% <100.00%> (ø)
app/components/Views/ChoosePassword/index.js 3.77% <0.00%> (+0.02%) ⬆️
app/components/Views/ConnectQRHardware/index.tsx 1.80% <0.00%> (+0.06%) ⬆️
app/components/Views/ManualBackupStep2/index.js 3.57% <0.00%> (ø)
app/components/Views/ManualBackupStep1/index.js 3.84% <0.00%> (ø)
app/core/BackgroundBridge/BackgroundBridge.js 5.40% <0.00%> (ø)
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sethkfman @leotm
Update .github/dependabot.yml
c7bcb09 
Update team label

Co-authored-by: LeoTM <1881059+leotm@users.noreply.github.com>
sethkfman
sethkfman approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sethkfman sethkfman merged commit 23555b8 into main Oct 5, 2023
25 checks passed
@sethkfman sethkfman deleted the fix/dependabot-pr-missing-team-label branch October 5, 2023 09:07
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

@legobeat legobeat Awaiting requested review from legobeat

Assignees
No one assigned
Labels
release-7.10.0 team-security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@leotm @codecov-commenter @sethkfman @metamaskbot