Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ramp): refactor quotes view copy and list #7389

Merged
merged 2 commits into from
Oct 5, 2023
Merged

refactor(ramp): refactor quotes view copy and list #7389

merged 2 commits into from
Oct 5, 2023

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Oct 4, 2023

Description

This PR changes the copy and list of quotes in the Buy flow

Manual testing steps

  1. Go to buy flow
  2. Select Payment Method, Input amount and Get Quotes
  3. Confirm the quotes screen has the new copy and design

Screenshots/Recordings

Before

After

Related issues

Fixes #???

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features needs-ramp-qa Tickets that need feature QA on the ramps flows labels Oct 4, 2023
@wachunei wachunei requested a review from a team as a code owner October 4, 2023 22:05
@bkirb
Copy link
Contributor

bkirb commented Oct 4, 2023

@wachunei LGTM I verified the copy and list change

@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@wachunei wachunei added ramp-qa-passed and removed needs-ramp-qa Tickets that need feature QA on the ramps flows labels Oct 4, 2023
sethkfman
sethkfman approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 5, 2023
@wachunei wachunei merged commit b2cf034 into main Oct 5, 2023
27 checks passed
@wachunei wachunei deleted the fix/ramp-quotes-copy branch October 5, 2023 14:44
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
ramp-qa-passed release-7.9.0 team-ramp issues related to Ramp features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wachunei @bkirb @sethkfman @hesterbruikman @metamaskbot