Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ramp): update quote cta copy #7411

Merged
merged 4 commits into from
Oct 10, 2023
Merged

feat(ramp): update quote cta copy #7411

merged 4 commits into from
Oct 10, 2023

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Oct 6, 2023 •
edited

Description

This PR changes the Buy flow quote CTA copy from "Buy with {{provider name}}" to "Continue with {{provider name}}"

Manual testing steps

  1. Open the buy flow and get quotes
  2. Quotes must have "Continue with.." as CTA

Screenshots/Recordings

Before

After

Related issues

Fixes #???

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features labels Oct 6, 2023
@wachunei wachunei requested a review from a team as a code owner October 6, 2023 21:09
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (24b4b7e) 34.61% compared to head (47522a2) 34.61%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7411   +/-   ##
=======================================
  Coverage   34.61%   34.61%           
=======================================
  Files        1017     1017           
  Lines       27162    27162           
  Branches     2211     2211           
=======================================
  Hits         9402     9402           
  Misses      17273    17273           
  Partials      487      487
Files Coverage Δ
app/components/UI/Ramp/components/Quote/Quote.tsx 45.94% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tommasini
tommasini approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

NicolasMassart
NicolasMassart approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 10, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wachunei wachunei merged commit 2c30c49 into main Oct 10, 2023
35 checks passed
@wachunei wachunei deleted the feat/ramp-quote-cta-copy branch October 10, 2023 14:24
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NicolasMassart NicolasMassart NicolasMassart approved these changes

@tommasini tommasini tommasini approved these changes

Assignees
No one assigned
Labels
release-7.9.0 release-7.10.0 team-ramp issues related to Ramp features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@wachunei @codecov-commenter @NicolasMassart @tommasini @hesterbruikman @metamaskbot