Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Feat/1273 duplicate contact addresses i18n #7465

Merged
merged 5 commits into from
Oct 11, 2023

Conversation

frankvonhoven
Copy link
Contributor

Description

Adds new entry into i18n for duplicate address bottom sheet copy

Related issues

Related to 1273

@frankvonhoven frankvonhoven requested a review from a team as a code owner October 10, 2023 21:08
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (72f73f1) 34.59% compared to head (21e20c2) 34.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7465   +/-   ##
=======================================
  Coverage   34.59%   34.59%           
=======================================
  Files        1019     1019           
  Lines       27192    27192           
  Branches     2212     2212           
=======================================
  Hits         9408     9408           
  Misses      17296    17296           
  Partials      488      488           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. team-mobile-client labels Oct 11, 2023
@Cal-L Cal-L changed the title Feat/1273 duplicate contact addresses i18n feat:Feat/1273 duplicate contact addresses i18n Oct 11, 2023
@frankvonhoven frankvonhoven merged commit 19d8a77 into main Oct 11, 2023
25 of 27 checks passed
@frankvonhoven frankvonhoven deleted the feat/1273-duplicate-contact-addresses-i18n branch October 11, 2023 20:44
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.10.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants