Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Convert Sheet stories to csf format #7471

Merged
merged 2 commits into from
Nov 17, 2023
Merged

refactor: Convert Sheet stories to csf format #7471

merged 2 commits into from
Nov 17, 2023

Conversation

brianacnguyen
Copy link
Contributor

Description

  • Converted stories for SheetHeader and SheetBottom

Screenshots/Recordings

Simulator Screen Shot - iPhone 14 Pro - 2023-10-10 at 18 46 02
Simulator Screen Shot - iPhone 14 Pro - 2023-10-10 at 18 46 06
Simulator Screen Shot - iPhone 14 Pro - 2023-10-10 at 18 46 09
Simulator Screen Shot - iPhone 14 Pro - 2023-10-10 at 18 46 12

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile labels Oct 11, 2023
@brianacnguyen brianacnguyen self-assigned this Oct 11, 2023
@brianacnguyen brianacnguyen requested a review from a team as a code owner October 11, 2023 01:48
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023 •
edited

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (ad2986f) 35.06% compared to head (9ff18b6) 35.07%.

Files Patch % Lines
...mponents/Sheet/SheetHeader/SheetHeader.stories.tsx 0.00% 4 Missing ⚠️
...mponents/Sheet/SheetBottom/SheetBottom.stories.tsx 0.00% 2 Missing ⚠️
...ponents/Sheet/SheetHeader/SheetHeader.constants.ts 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7471   +/-   ##
=======================================
  Coverage   35.06%   35.07%           
=======================================
  Files        1040     1040           
  Lines       27669    27664    -5     
  Branches     2345     2342    -3     
=======================================
+ Hits         9702     9703    +1     
+ Misses      17442    17436    -6     
  Partials      525      525

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

11.1% 11.1% Coverage
0.0% 0.0% Duplication

tommasini
tommasini previously approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tommasini
Copy link
Contributor

Curious question, what happens if the name of the title and the top right button are bigger?

georgewrmarshall
georgewrmarshall previously approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left some non-blocking comments

  • pulled branch and checked stories and contorls

Not apart of the issue but should this truncate?

Screenshot 2023-10-24 at 12 58 45 PM

.storybook/main.js Show resolved Hide resolved
app/component-library/components/Sheet/SheetBottom/SheetBottom.stories.tsx Show resolved Hide resolved
@brianacnguyen
Copy link
Contributor Author

Curious question, what happens if the name of the title and the top right button are bigger?

the title will overflow to multiple lines and will center around start and end accessories

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

11.1% 11.1% Coverage
0.0% 0.0% Duplication

@brianacnguyen brianacnguyen merged commit eb69e57 into main Nov 17, 2023
26 checks passed
@brianacnguyen brianacnguyen deleted the morph/convert-sheet branch November 17, 2023 00:49
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 17, 2023
@metamaskbot metamaskbot added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@georgewrmarshall georgewrmarshall georgewrmarshall approved these changes

@tommasini tommasini tommasini left review comments

Assignees

@brianacnguyen brianacnguyen

Labels
release-7.12.0 Issue or pull request that will be included in release 7.12.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-design-system All issues relating to design system in Mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@brianacnguyen @codecov-commenter @tommasini @georgewrmarshall @metamaskbot