Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Migrate 'Approve Custom ERC20 Token Amount' to Detox #7473

Merged
merged 8 commits into from
Oct 13, 2023
Merged

test: Migrate 'Approve Custom ERC20 Token Amount' to Detox #7473

merged 8 commits into from
Oct 13, 2023

Conversation

sleepytanya
Copy link
Contributor

@sleepytanya sleepytanya commented Oct 11, 2023 •
edited

Description

_This PR migrates 'Approve Custom ERC20 Token' E2E test to Detox. I also made some minor changes to 'Approve Default ERC20 Token' test.

Screenshot 2023-10-13 at 11 57 14 AM Screenshot 2023-10-13 at 11 59 18 AM

Fixes #937

Bitrise run.

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sleepytanya sleepytanya requested a review from a team as a code owner October 11, 2023 03:09
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sleepytanya sleepytanya added team-confirmations-system DEPRECATED: please use "team-confirmations" label instead No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. labels Oct 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023 •
edited

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (23bf3c2) 34.62% compared to head (3d1360e) 34.62%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7473   +/-   ##
=======================================
  Coverage   34.62%   34.62%           
=======================================
  Files        1019     1019           
  Lines       27192    27192           
  Branches     2217     2217           
=======================================
  Hits         9414     9414           
  Misses      17287    17287           
  Partials      491      491

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Andepande
Andepande previously approved these changes Oct 11, 2023
View reviewed changes
@Andepande Andepande dismissed their stale review October 11, 2023 16:05

need re-review

Andepande
Andepande reviewed Oct 13, 2023
View reviewed changes
Copy link
Member

@Andepande Andepande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comment

@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Andepande
Andepande approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@Andepande Andepande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sleepytanya sleepytanya merged commit 3d694ae into main Oct 13, 2023
25 checks passed
@sleepytanya sleepytanya deleted the migrate-custom-erc20-to-detox branch October 13, 2023 21:32
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SamuelSalas SamuelSalas SamuelSalas left review comments

@Andepande Andepande Andepande approved these changes

Assignees
No one assigned
Labels
No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.10.0 team-confirmations-system DEPRECATED: please use "team-confirmations" label instead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sleepytanya @codecov-commenter @SamuelSalas @Andepande @metamaskbot