-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wc2 invalid origin in analytics #7474
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7474 +/- ##
==========================================
- Coverage 34.61% 34.59% -0.02%
==========================================
Files 1017 1019 +2
Lines 27165 27193 +28
Branches 2211 2212 +1
==========================================
+ Hits 9402 9408 +6
- Misses 17276 17297 +21
- Partials 487 488 +1
☔ View full report in Codecov by Sentry. |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
All good with testing. Logs observed:
|
Description
Analytics sending invalid request source on wallet connect transaction because the origin wasn't parsed correctly.
fixes https://app.zenhub.com/workspaces/metamask-sdk-6359297a36f20292c13feca0/issues/gh/metamask/metamask-sdk/269
Manual testing steps
Use wallet connect v2 dapp to send a transaction to mobile wallet. https://github.com/WalletConnect/walletconnect-example-dapp
Before
After