Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing redirect on deepllink after connection #7476

Merged
merged 1 commit into from
Oct 13, 2023
Merged

fix: missing redirect on deepllink after connection #7476

merged 1 commit into from
Oct 13, 2023

Conversation

abretonc7s
Copy link
Contributor

Description

Sometime the deeplink status is not fully detected and automatically resetting it would lead to wallet not redirecting to dapp after user action.

Manual testing steps

Follow steps on related issue.

_Fixes #7084

@abretonc7s abretonc7s requested a review from a team as a code owner October 11, 2023 11:11
@abretonc7s abretonc7s mentioned this pull request Oct 11, 2023
Closed
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@abretonc7s abretonc7s added needs-qa Any New Features that needs a full manual QA prior to being added to a release. team-sdk SDK team WalletConnect WalletConnect related issue or bug labels Oct 11, 2023
andreahaku
andreahaku approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@christopherferreira9 christopherferreira9 added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Oct 11, 2023
@christopherferreira9
Copy link
Contributor

Tested and the issue is fixed.

Test Case:

  • Start with a clean state
  • Connect & Sign to an android app that uses WalletConnect like Opensea
  • Logout on Opensea
  • Kill & Open the opensea app
  • Connect & Sign

Expected result:
You should be sent back from MetaMask to the Opensea app everytime you do a "Connect - Sign" flow

Screen.Recording.2023-10-12.at.11.04.44.mov

@christopherferreira9 christopherferreira9 added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Oct 12, 2023
@codepgq codepgq mentioned this pull request Oct 12, 2023
Closed
@christopherferreira9 christopherferreira9 merged commit 12a0f63 into main Oct 13, 2023
29 of 33 checks passed
@christopherferreira9 christopherferreira9 deleted the fix/wc2-missing-redirect branch October 13, 2023 08:06
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andreahaku andreahaku andreahaku approved these changes

Assignees

@andreahaku andreahaku

@christopherferreira9 christopherferreira9

Labels
QA Passed A successful QA run through has been done release-7.10.0 team-sdk SDK team WalletConnect WalletConnect related issue or bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@abretonc7s @christopherferreira9 @andreahaku @metamaskbot