Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix failing wallet E2E test on main #7510

Merged
merged 1 commit into from
Oct 16, 2023
Merged

test: Fix failing wallet E2E test on main #7510

merged 1 commit into from
Oct 16, 2023

Conversation

cortisiko
Copy link
Member

Description

This PR addresses the issue where we have failing e2e tests on the main branch.

Manual testing steps

1. Step1:
2. Step2:
3. ...

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change.

Before

[screenshot]

After

[screenshot]

Related issues

Fixes #???

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cortisiko cortisiko requested a review from a team as a code owner October 16, 2023 21:59
@cortisiko cortisiko added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. E2E labels Oct 16, 2023
@SamuelSalas
Copy link
Member

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Cal-L
Cal-L approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko merged commit a96030a into main Oct 16, 2023
25 of 28 checks passed
@cortisiko cortisiko deleted the detox/fix-wallet-test branch October 16, 2023 22:47
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

@SamuelSalas SamuelSalas SamuelSalas approved these changes

Assignees
No one assigned
Labels
E2E No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. release-7.10.0 team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cortisiko @SamuelSalas @Cal-L @gauthierpetetin @metamaskbot