Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(issue template): placeholder text #7518

Merged
merged 1 commit into from
Oct 17, 2023
Merged

fix(issue template): placeholder text #7518

merged 1 commit into from
Oct 17, 2023

Conversation

gauthierpetetin
Copy link
Contributor

Description

  • The placeholder text shall indicate the the issue shall be described from a user standpoint.

Manual testing steps

  • Create a new issue.

Screenshots/Recordings

NA

Before

NA

After

NA

Related issues

NA

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gauthierpetetin
fix(issue template): placeholder text
d6c2cb5 
The placeholder text shall indicate the the issue shall be described from a user standpoint.
@gauthierpetetin gauthierpetetin self-assigned this Oct 17, 2023
@gauthierpetetin gauthierpetetin requested a review from a team as a code owner October 17, 2023 13:24
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sonarcloud
Copy link

sonarcloud bot commented Oct 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sethkfman
sethkfman approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gauthierpetetin gauthierpetetin merged commit 0a598c5 into main Oct 17, 2023
27 checks passed
@gauthierpetetin gauthierpetetin deleted the fix/issue-template-placeholder branch October 17, 2023 17:39
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees

@gauthierpetetin gauthierpetetin

Labels
release-7.10.0 team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gauthierpetetin @sethkfman @metamaskbot