Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: depcheck@^1.4.5->^1.4.7 #7531

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 18, 2023

Description

Bump depcheck and dedupe babel packages.

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added dependencies Pull requests that update a dependency file team-security labels Oct 18, 2023
@socket-security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
depcheck 1.4.5...1.4.7 None +3/-4 987 kB rumpl

@legobeat legobeat changed the title devDeps: depcheck@^1.4.5->^1.4.7 fix: depcheck@^1.4.5->^1.4.7 Oct 18, 2023
@legobeat legobeat marked this pull request as ready for review October 18, 2023 06:27
@legobeat legobeat requested a review from a team as a code owner October 18, 2023 06:27
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (de4e4d0) 34.61% compared to head (1e8059b) 34.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7531   +/-   ##
=======================================
  Coverage   34.61%   34.61%           
=======================================
  Files        1019     1019           
  Lines       27193    27193           
  Branches     2218     2218           
=======================================
  Hits         9413     9413           
  Misses      17289    17289           
  Partials      491      491           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@socket-security
Copy link

socket-security bot commented Oct 18, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@legobeat
Copy link
Contributor Author

@SocketSecurity ignore koa-compose@4.1.0

new author ok

@legobeat legobeat merged commit b5c2b9a into MetaMask:main Oct 19, 2023
24 checks passed
@legobeat legobeat deleted the devdeps-depcheck branch October 19, 2023 16:54
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file team-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants