feat: Add EIP-6963 Provider #7541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package.json # yarn.lock
# Conflicts: # .depcheckrc.yml # package.json # yarn.lock
# Conflicts: # scripts/build-inpage-bridge.sh
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
jiexi
commented
Oct 18, 2023
jiexi
commented
Oct 18, 2023
|
The assumption here is that Mobile Flask is built off a different branch, thus no build time variables are needed to determine the EIP6963 provider name, icon, and rdns values |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7541 +/- ##
=======================================
Coverage 34.61% 34.61%
=======================================
Files 1019 1019
Lines 27193 27193
Branches 2218 2218
=======================================
Hits 9413 9413
Misses 17289 17289
Partials 491 491 ☔ View full report in Codecov by Sentry. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Pulled down Simulator.Screen.Recording.-.iPhone.12.Pro.-.2023-10-31.at.12.42.38.mp4 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump
@metamask/providersto v13.1.0 which includes EIP6963 support. Pass necessary provider info values to the inpage bridge script to properly initialize the provider.Manual testing steps
Screenshots/Recordings
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/869
Pre-merge author checklist
Pre-merge reviewer checklist