Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: @metamask/test-dapp@^7.1.0->^7.2.0 #7542

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

legobeat
Copy link
Contributor

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@legobeat legobeat added dependencies Pull requests that update a dependency file team-security labels Oct 19, 2023
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/test-dapp 7.2.0 None +0 4.94 MB mcmire

@socket-security
Copy link

socket-security bot commented Oct 19, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: @metamask/test-dapp@7.2.0

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat
Copy link
Contributor Author

@SocketSecurity ignore @metamask/test-dapp@7.2.0

@legobeat legobeat marked this pull request as ready for review October 19, 2023 07:59
@legobeat legobeat requested a review from a team as a code owner October 19, 2023 07:59
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (de4e4d0) 34.61% compared to head (5e646bd) 34.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7542   +/-   ##
=======================================
  Coverage   34.61%   34.61%           
=======================================
  Files        1019     1019           
  Lines       27193    27193           
  Branches     2218     2218           
=======================================
  Hits         9413     9413           
  Misses      17289    17289           
  Partials      491      491           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seaona seaona mentioned this pull request Oct 19, 2023
14 tasks
@legobeat legobeat merged commit fe6c4a7 into MetaMask:main Oct 19, 2023
27 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2023
@legobeat legobeat deleted the devDeps-test-dapp branch October 19, 2023 16:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file team-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants