-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix link to testnet faucets #7546
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7546 +/- ##
=======================================
Coverage 34.65% 34.65%
=======================================
Files 1023 1023
Lines 27338 27346 +8
Branches 2242 2242
=======================================
+ Hits 9473 9478 +5
- Misses 17367 17370 +3
Partials 498 498
☔ View full report in Codecov by Sentry. |
… into faucet_link_fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
… into faucet_link_fix
Kudos, SonarCloud Quality Gate passed! |
Description
Fix the link to testnet faucets.
Manual testing steps
_1. Start a transaction and go to confirmation page (ensure that you have less that required ETH on the testnet)
_2. Click the buy option, it should load correct faucet page
Related issues
_Fixes: MetaMask/mobile-planning#1255
Pre-merge author checklist
Pre-merge reviewer checklist