Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to testnet faucets #7546

Merged
merged 15 commits into from
Oct 24, 2023
Merged

Fix link to testnet faucets #7546

merged 15 commits into from
Oct 24, 2023

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Oct 19, 2023

Description

Fix the link to testnet faucets.

Manual testing steps

_1. Start a transaction and go to confirmation page (ensure that you have less that required ETH on the testnet)
_2. Click the buy option, it should load correct faucet page

Related issues

_Fixes: MetaMask/mobile-planning#1255

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead label Oct 19, 2023
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d2623c8) 34.65% compared to head (888febf) 34.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7546   +/-   ##
=======================================
  Coverage   34.65%   34.65%           
=======================================
  Files        1023     1023           
  Lines       27338    27346    +8     
  Branches     2242     2242           
=======================================
+ Hits         9473     9478    +5     
- Misses      17367    17370    +3     
  Partials      498      498           
Files Coverage Δ
app/constants/urls.ts 100.00% <100.00%> (ø)
app/core/AppConstants.ts 80.00% <ø> (ø)
app/util/networks/index.js 75.93% <100.00%> (+0.55%) ⬆️
...pp/components/UI/ApproveTransactionReview/index.js 3.84% <0.00%> (-0.02%) ⬇️
...actionReview/TransactionReviewInformation/index.js 37.16% <0.00%> (-0.34%) ⬇️
app/components/Views/SendFlow/Confirm/index.js 43.79% <0.00%> (-0.17%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpuri jpuri marked this pull request as ready for review October 19, 2023 16:11
@jpuri jpuri requested a review from a team as a code owner October 19, 2023 16:11
segun
segun previously approved these changes Oct 19, 2023
@bschorchit bschorchit added team-confirmations-secure-ux-PR PR from the confirmations team and removed team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead labels Oct 19, 2023
@jpuri jpuri added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 23, 2023
blackdevelopa
blackdevelopa previously approved these changes Oct 23, 2023
Copy link
Contributor

@blackdevelopa blackdevelopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

digiwand
digiwand previously approved these changes Oct 23, 2023
@jpuri jpuri dismissed stale reviews from digiwand and blackdevelopa via 9ac697c October 23, 2023 13:43
@jpuri jpuri requested review from segun and digiwand October 24, 2023 10:02
@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

39.1% 39.1% Coverage
0.0% 0.0% Duplication

@jpuri
Copy link
Contributor Author

jpuri commented Oct 24, 2023

@jpuri jpuri merged commit 03bf584 into main Oct 24, 2023
25 checks passed
@jpuri jpuri deleted the faucet_link_fix branch October 24, 2023 17:48
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 24, 2023
@metamaskbot metamaskbot added the release-7.11.0 Issue or pull request that will be included in release 7.11.0 label Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.11.0 Issue or pull request that will be included in release 7.11.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants