chore: run yarn install as part of yarn deduplicate
#7568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
legobeat
changed the title
yarn install as part of yarn dedupeyarn install as part of yarn deduplicate
legobeat
force-pushed
the
dedupe-and-install
branch
from
d8dbddc
to
0d8e0c6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7568 +/- ##
=======================================
Coverage 34.97% 34.97%
=======================================
Files 1030 1030
Lines 27379 27379
Branches 2253 2253
=======================================
Hits 9577 9577
Misses 17292 17292
Partials 510 510 ☔ View full report in Codecov by Sentry. |
legobeat
force-pushed
the
dedupe-and-install
branch
from
0d8e0c6
to
f681843
Compare
legobeat
force-pushed
the
dedupe-and-install
branch
3 times, most recently
from
6917f82
to
addff8b
Compare
legobeat
force-pushed
the
dedupe-and-install
branch
5 times, most recently
from
0bb07dd
to
9d27e7c
Compare
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Running `yarn install` seems necessary to sync lockfile after `yarn deduplicate`. This was already done in CI. This makes it happen when running the script locally, too.
legobeat
force-pushed
the
dedupe-and-install
branch
from
9d27e7c
to
9901fed
Compare
leotm
approved these changes
Oct 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Running
yarn installseems necessary to sync lockfile afteryarn deduplicate.This was already done in CI. This makes it happen when running the script locally, too.
Manual testing steps
yarn deduplicateand commit resultRelated issues
Pre-merge author checklist
Pre-merge reviewer checklist