Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [Part 2] - Ongoing Work for legacy <Text> comp replacement. #7571

Merged
merged 8 commits into from
Oct 27, 2023

Conversation

Jonathansoufer
Copy link
Contributor

@Jonathansoufer Jonathansoufer commented Oct 23, 2023

Description

This PR replaces old usage of legacy component with the text component that standardizes on typography provided through theme via @metamask/design-tokens library. This will bring uniformity to all text elements on our app.

Manual testing steps

  • From the main screen, click on any asset available to go to Asset Detail.
  • Chose different timeframes on the Chart.
  • Review Texts from Price & Charts.

Screenshots/Recordings

Before

Screenshot 2023-10-23 at 14 20 23

After

Screenshot 2023-10-25 at 09 33 09

Related issues

This is part of ongoing tasks related to issue #6887

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Jonathansoufer Jonathansoufer added the team-design-system All issues relating to design system in Mobile label Oct 23, 2023
@Jonathansoufer Jonathansoufer self-assigned this Oct 23, 2023
@Jonathansoufer Jonathansoufer requested a review from a team as a code owner October 23, 2023 15:10
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (4fb2b2b) 34.85% compared to head (cc7b1be) 34.85%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7571   +/-   ##
=======================================
  Coverage   34.85%   34.85%           
=======================================
  Files        1028     1028           
  Lines       27424    27424           
  Branches     2267     2267           
=======================================
  Hits         9558     9558           
  Misses      17356    17356           
  Partials      510      510           
Files Coverage Δ
...nts/UI/AssetOverview/AboutAsset/ContentDisplay.tsx 0.00% <ø> (ø)
...ew/ChartNavigationButton/ChartNavigationButton.tsx 33.33% <ø> (ø)
...components/UI/AssetOverview/Price/Price.styles.tsx 16.66% <ø> (ø)
.../UI/AssetOverview/PriceChart/PriceChart.styles.tsx 40.00% <ø> (ø)
...ponents/UI/AssetOverview/PriceChart/PriceChart.tsx 1.40% <ø> (ø)
...AssetOverview/AboutAsset/ContentDisplay.styles.tsx 0.00% <0.00%> (ø)
...tNavigationButton/ChartNavigationButton.styles.tsx 16.66% <0.00%> (ø)
app/components/UI/AssetOverview/Price/Price.tsx 4.34% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@owencraston owencraston requested review from georgewrmarshall and brianacnguyen and removed request for georgewrmarshall October 23, 2023 21:25
@Jonathansoufer
Copy link
Contributor Author

Screenshots updated after changes as well.

@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Jonathansoufer Jonathansoufer merged commit d894f7e into main Oct 27, 2023
25 checks passed
@Jonathansoufer Jonathansoufer deleted the refactor/text-comp-replacement-part-2 branch October 27, 2023 09:24
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2023
@metamaskbot metamaskbot added the release-7.11.0 Issue or pull request that will be included in release 7.11.0 label Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.11.0 Issue or pull request that will be included in release 7.11.0 team-design-system All issues relating to design system in Mobile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants