Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cherry pick #7540 #7580

Merged
merged 2 commits into from
Oct 24, 2023
Merged

chore: Cherry pick #7540 #7580

merged 2 commits into from
Oct 24, 2023

Conversation

sethkfman
Copy link
Contributor

Description

Release cherry-pick #7540

Co-authored-by: Cal Leung <cleun007@gmail.com>
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (60a3af2) 34.72% compared to head (55c7a6a) 34.69%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/7.10.0    #7580      +/-   ##
==================================================
- Coverage           34.72%   34.69%   -0.04%     
==================================================
  Files                1022     1020       -2     
  Lines               27279    27249      -30     
  Branches             2232     2228       -4     
==================================================
- Hits                 9472     9453      -19     
+ Misses              17309    17301       -8     
+ Partials              498      495       -3     
Files Coverage Δ
app/constants/error.ts 100.00% <100.00%> (ø)
app/core/RPCMethods/index.js 100.00% <ø> (ø)
app/core/RPCMethods/RPCMethodMiddleware.ts 46.06% <0.00%> (ø)
app/core/RPCMethods/wallet_watchAsset.ts 82.60% <82.60%> (ø)
app/components/UI/AddCustomToken/index.js 30.90% <22.22%> (ø)

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

60.7% 60.7% Coverage
0.0% 0.0% Duplication

@chrisleewilcox chrisleewilcox added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking QA Passed A successful QA run through has been done labels Oct 24, 2023
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisleewilcox chrisleewilcox merged commit eca37f5 into release/7.10.0 Oct 24, 2023
24 checks passed
@chrisleewilcox chrisleewilcox deleted the cherry-pick-rc/7540 branch October 24, 2023 22:48
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done release-7.10.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-platform type-bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants