Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: revert transfer DeeplinkManager.js file to TS #7597

Merged
merged 1 commit into from
Oct 25, 2023
Merged

chore: revert transfer DeeplinkManager.js file to TS #7597

merged 1 commit into from
Oct 25, 2023

Conversation

omridan159
Copy link
Contributor

Reverts #7586

@omridan159 omridan159 requested a review from a team as a code owner October 25, 2023 07:57
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

abretonc7s
abretonc7s approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@abretonc7s abretonc7s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@omridan159 omridan159 changed the title Revert "chore: transfer DeeplinkManager.js file to TS" chore: revert transfer DeeplinkManager.js file to TS Oct 25, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (cae93c4) 34.65% compared to head (0514306) 34.66%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7597   +/-   ##
=======================================
  Coverage   34.65%   34.66%           
=======================================
  Files        1023     1023           
  Lines       27346    27345    -1     
  Branches     2282     2242   -40     
=======================================
+ Hits         9477     9478    +1     
+ Misses      17371    17369    -2     
  Partials      498      498
Files Coverage Δ
app/constants/deeplinks.ts 100.00% <ø> (ø)
app/core/DeeplinkManager.js 1.26% <5.88%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

0.8% 0.8% Coverage
9.4% 9.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@omridan159 omridan159 merged commit 55848ab into main Oct 25, 2023
25 of 28 checks passed
@omridan159 omridan159 deleted the revert-7586-chore_transfer-DeeplinkManager-file-to-TS branch October 25, 2023 08:14
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2023
@metamaskbot metamaskbot added the release-7.11.0 Issue or pull request that will be included in release 7.11.0 label Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abretonc7s abretonc7s abretonc7s approved these changes

Assignees
No one assigned
Labels
release-7.11.0 Issue or pull request that will be included in release 7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@omridan159 @codecov-commenter @abretonc7s @metamaskbot