Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: split sdk connect #7600

Merged
merged 3 commits into from
Oct 26, 2023
Merged

chore: split sdk connect #7600

merged 3 commits into from
Oct 26, 2023

Conversation

abretonc7s
Copy link
Contributor

@abretonc7s abretonc7s commented Oct 25, 2023

Description

Split SDKConnect in two separate classes. Exact same behavior or functionalities just to make the code more readable into multiple files. This is the first step to continue modularizing the codebase for easier unit testing.

Manual testing steps

Regular dapp flow connect with sdk.

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • [ x] I’ve followed MetaMask Coding Standards.
  • [ x] I've clearly explained what problem this PR is solving and how it is solved.
  • [ x] I've linked related issues
  • [ x] I've included manual testing steps
  • [ x] I've included screenshots/recordings if applicable
  • [ x] I’ve included tests if applicable
  • [ x] I’ve documented my code using JSDoc format if applicable
  • [ x] I’ve applied the right labels on the PR (see labeling guidelines).
  • [ x] I’ve properly set the pull request status:
    • [ x] In case it's not yet "ready for review", I've set it to "draft".
    • [ x] In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@abretonc7s abretonc7s marked this pull request as ready for review October 25, 2023 10:47
@abretonc7s abretonc7s requested a review from a team as a code owner October 25, 2023 10:47
Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

0.6% 0.6% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Attention: 233 lines in your changes are missing coverage. Please review.

Comparison is base (9a31999) 34.85% compared to head (2f24b43) 34.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7600   +/-   ##
=======================================
  Coverage   34.85%   34.85%           
=======================================
  Files        1027     1028    +1     
  Lines       27423    27423           
  Branches     2267     2267           
=======================================
  Hits         9558     9558           
  Misses      17355    17355           
  Partials      510      510           
Files Coverage Δ
app/core/SDKConnect/SDKConnect.ts 2.73% <100.00%> (+1.02%) ⬆️
app/core/SDKConnect/utils/wait.util.ts 14.00% <ø> (ø)
app/core/SDKConnect/Connection.ts 0.42% <0.42%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christopherferreira9 christopherferreira9 added needs-qa Any New Features that needs a full manual QA prior to being added to a release. QA in Progress QA has started on the feature. team-sdk SDK team and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Oct 26, 2023
@christopherferreira9
Copy link
Contributor

QA Passed after smoke testing in all SDKs.

@christopherferreira9 christopherferreira9 added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Oct 26, 2023
@christopherferreira9 christopherferreira9 merged commit 4fb2b2b into main Oct 26, 2023
30 of 31 checks passed
@christopherferreira9 christopherferreira9 deleted the chore/split-sdkconnect branch October 26, 2023 16:38
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
@metamaskbot metamaskbot added the release-7.11.0 Issue or pull request that will be included in release 7.11.0 label Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done release-7.11.0 Issue or pull request that will be included in release 7.11.0 team-sdk SDK team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants