-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: split sdk connect #7600
chore: split sdk connect #7600
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7600 +/- ##
=======================================
Coverage 34.85% 34.85%
=======================================
Files 1027 1028 +1
Lines 27423 27423
Branches 2267 2267
=======================================
Hits 9558 9558
Misses 17355 17355
Partials 510 510
☔ View full report in Codecov by Sentry. |
QA Passed after smoke testing in all SDKs. |
Description
Split SDKConnect in two separate classes. Exact same behavior or functionalities just to make the code more readable into multiple files. This is the first step to continue modularizing the codebase for easier unit testing.
Manual testing steps
Regular dapp flow connect with sdk.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist