-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: approve deeplink displays domain pill with selected address #7601
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7601 +/- ##
=======================================
Coverage 34.84% 34.85%
=======================================
Files 1030 1030
Lines 27425 27426 +1
Branches 2262 2262
=======================================
+ Hits 9557 9560 +3
+ Misses 17358 17357 -1
+ Partials 510 509 -1
☔ View full report in Codecov by Sentry. |
165c5e0
to
06c1c9a
Compare
@blackdevelopa the PR looks good from QA. I can see how the origin pill is not displayed when using deeplinks. With the dapp transactions, I can still see how the origin is displayed correctly. deeplink-approve-pill.mp4 |
Kudos, SonarCloud Quality Gate passed! |
Description
When the transaction origin is
qr-code
, we shouldn't show the origin pill. See ref 5570Related issues
Fixes: #7545
Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/07a2a3fd-2fff-4242-a754-e8f45d455cb4
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist