Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: approve deeplink displays domain pill with selected address #7601

Merged
merged 4 commits into from
Nov 6, 2023

Conversation

blackdevelopa
Copy link
Contributor

@blackdevelopa blackdevelopa commented Oct 25, 2023

Description

When the transaction origin is qr-code, we shouldn't show the origin pill. See ref 5570

Related issues

Fixes: #7545
Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/07a2a3fd-2fff-4242-a754-e8f45d455cb4

Manual testing steps

  1. Select Mainnet
  2. Trigger a Deeplink
  3. See domain pill appears with the selected address

Screenshot from 2023-10-19 14-50-01

Screenshots/Recordings

Before

Screenshot from 2023-10-19 14-14-16

After

IMG_9310

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@blackdevelopa blackdevelopa requested a review from a team as a code owner October 25, 2023 10:53
@blackdevelopa blackdevelopa self-assigned this Oct 25, 2023
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@blackdevelopa blackdevelopa added the team-confirmations-secure-ux-PR PR from the confirmations team label Oct 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (ee98179) 34.84% compared to head (260e939) 34.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7601   +/-   ##
=======================================
  Coverage   34.84%   34.85%           
=======================================
  Files        1030     1030           
  Lines       27425    27426    +1     
  Branches     2262     2262           
=======================================
+ Hits         9557     9560    +3     
+ Misses      17358    17357    -1     
+ Partials      510      509    -1     
Files Coverage Δ
...actionHeader/ApproveTransactionHeader.constants.ts 100.00% <100.00%> (ø)
...roveTransactionHeader/ApproveTransactionHeader.tsx 79.54% <66.66%> (+4.54%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackdevelopa blackdevelopa added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 25, 2023
segun
segun previously approved these changes Oct 25, 2023
jpuri
jpuri previously approved these changes Oct 25, 2023
@blackdevelopa blackdevelopa removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 25, 2023
@seaona
Copy link
Contributor

seaona commented Nov 2, 2023

@blackdevelopa the PR looks good from QA. I can see how the origin pill is not displayed when using deeplinks.
In the details, I can see how the origin is qr-code.

With the dapp transactions, I can still see how the origin is displayed correctly.

deeplink-approve-pill.mp4

Screenshot from 2023-11-02 13-12-27

@seaona seaona added the QA Passed A successful QA run through has been done label Nov 2, 2023
Copy link

sonarcloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.0% 81.0% Coverage
0.0% 0.0% Duplication

@blackdevelopa blackdevelopa merged commit 4217a2d into main Nov 6, 2023
29 checks passed
@blackdevelopa blackdevelopa deleted the 7545/domain_pill_deeplink branch November 6, 2023 11:35
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2023
@metamaskbot metamaskbot added the release-7.11.0 Issue or pull request that will be included in release 7.11.0 label Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done release-7.11.0 Issue or pull request that will be included in release 7.11.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Approve deeplink displays domain pill with selected address
6 participants