Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show message on UI when blockaid validation fails #7618

Merged
merged 5 commits into from
Oct 26, 2023
Merged

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Oct 26, 2023

Description

Display correct message on UI when blockaid validation fails.

Related issues

Fixes: #7513

Manual testing steps

  1. Enable blockaid abd submit transaction which can cause validation to fail.
  2. Confirmation page should show message "Request may not be safe"

Screenshots/Recordings

Screenshot 2023-10-26 at 7 10 12 PM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead labels Oct 26, 2023
@jpuri jpuri requested a review from a team as a code owner October 26, 2023 13:41
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 26, 2023
blackdevelopa
blackdevelopa previously approved these changes Oct 26, 2023
Copy link
Contributor

@blackdevelopa blackdevelopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's failing a snapshot test

segun
segun previously approved these changes Oct 26, 2023
@jpuri jpuri dismissed stale reviews from segun and blackdevelopa via 62d3f7d October 26, 2023 14:47
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@blackdevelopa blackdevelopa self-requested a review October 26, 2023 15:12
@jpuri jpuri requested a review from segun October 26, 2023 15:40
@jpuri jpuri merged commit 8df15aa into main Oct 26, 2023
25 checks passed
@jpuri jpuri deleted the blockaid_failed_requests branch October 26, 2023 15:47
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 26, 2023
@metamaskbot metamaskbot added the release-7.11.0 Issue or pull request that will be included in release 7.11.0 label Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-7.11.0 Issue or pull request that will be included in release 7.11.0 team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: PPOM - Request may not be safe not shown
4 participants